From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c9wx1-0000F2-Va for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:32:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c9wwx-0003YJ-VJ for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:32:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39942) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c9wwx-0003Wn-NI for qemu-devel@nongnu.org; Thu, 24 Nov 2016 11:32:39 -0500 References: <1479922617-4400-1-git-send-email-eblake@redhat.com> <87shqhi1a7.fsf@dusky.pond.sub.org> From: Eric Blake Message-ID: <23d73855-0700-f9d6-63f7-eca68df4e3a1@redhat.com> Date: Thu, 24 Nov 2016 10:32:36 -0600 MIME-Version: 1.0 In-Reply-To: <87shqhi1a7.fsf@dusky.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="asUDxGQ23xuEi0wis58laCGL15SotxXtj" Subject: Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, programmingkidx@gmail.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --asUDxGQ23xuEi0wis58laCGL15SotxXtj From: Eric Blake To: Markus Armbruster Cc: qemu-devel@nongnu.org, programmingkidx@gmail.com, pbonzini@redhat.com Message-ID: <23d73855-0700-f9d6-63f7-eca68df4e3a1@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 for-2.8 0/4] Fix MacOS runtime failure of qobject_from_jsonf() References: <1479922617-4400-1-git-send-email-eblake@redhat.com> <87shqhi1a7.fsf@dusky.pond.sub.org> In-Reply-To: <87shqhi1a7.fsf@dusky.pond.sub.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/24/2016 05:07 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> programmingkidx@gmail.com[*] reported a runtime failure on a >> 32-bit Mac OS compilation, where "%"PRId64 expands to "%qd". >> Fortunately, we had very few spots that were relying on our >> pseudo-printf JSON parsing of int64_t numbers, so it was >> easier to just convert callers to stick to safer %lld. >> >> The remaining uses of pseudo-printf handling are more complex; >> there are only 3 users in the released codebased, but LOTS of >> users in the testsuite (via wrapper functions like qmp()); I >> will be posting a followup series that rips out the remaining >> uses of dynamic JSON, but it will be 2.9 material, while >> these (first three) patches qualify for 2.8. The fourth patch >> is RFC; not intended to be applied now, but shows how I tested >> patch 3/4; it will probably reappear in the later 2.9 series. >=20 > I can take the first three through my tree. You mentioned some possible touchups - do you want to make those, or have me send a v3? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --asUDxGQ23xuEi0wis58laCGL15SotxXtj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYNxYkAAoJEKeha0olJ0Nq/oIH/i53zywEknB3yxetysISyD+s aVz6ttK7hwh6ecG8AJzXoUzZBTtZjdzY7WX4qWfvivFi2oVlUKMHUxUR8uvc2hFn VDrVPN6BVK5wpBF8bMyomKjfzyCJJ7WupNLXFnn41bkOxHdJKUxWADFu8nFGAk1I GZ4KWLOvapHIbgtSEhBuN634wUv1vy3qDbcUT3xdvvLbOIXxIQVwiRueeP+stMDW xYm47mvTkQBI1DnfIgajlfNJckp3cfeeO8piJTpgH1MovHDQp5aufUjujTBY9T/T V/7s/TwDs/bJrnOtIMqYhQkzWm70VYpreGjv972//63vabWb4erXsATkcft7bHc= =hAIk -----END PGP SIGNATURE----- --asUDxGQ23xuEi0wis58laCGL15SotxXtj--