Re: [PATCH] pc-bios: ensure installed ROMs don't have execute permissions

[Helge Deller <deller@gmx.de>]

On 5/30/25 17:21, Daniel P. Berrangé wrote:
> We have been inconsistent about whether ROMS stored in git have
> execute permission set, and by default meson will preserve source
> file permissions when installing files. This has caused periodic
> problems in RPM packaging as executable binary files get analysed
> by various tools/linters, which can trip up on the ROMs.
> 
> Tell meson explicitly that all the ROMs should be without execute
> permission when installed.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

Reviewed-by: Helge Deller <deller@gmx.de>
Tested-by: Helge Deller <deller@gmx.de>

Thanks!
Helge

> ---
>   pc-bios/meson.build | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pc-bios/meson.build b/pc-bios/meson.build
> index 79bb2e1800..3c41620044 100644
> --- a/pc-bios/meson.build
> +++ b/pc-bios/meson.build
> @@ -88,7 +88,7 @@ blobs = [
>   ]
>   
>   if get_option('install_blobs')
> -  install_data(blobs, install_dir: qemu_datadir)
> +  install_data(blobs, install_dir: qemu_datadir, install_mode: 'rw-r--r--')
>   endif
>   
>   subdir('descriptors')