From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BEC8C34022 for ; Mon, 17 Feb 2020 18:42:02 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 507CF22525 for ; Mon, 17 Feb 2020 18:42:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iiXTwH2a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 507CF22525 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:50686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3lLF-0000R3-HG for qemu-devel@archiver.kernel.org; Mon, 17 Feb 2020 13:42:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48154) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j3lK7-0007qR-UX for qemu-devel@nongnu.org; Mon, 17 Feb 2020 13:40:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j3lK7-0007OW-1k for qemu-devel@nongnu.org; Mon, 17 Feb 2020 13:40:51 -0500 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:35339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j3lK6-0007OG-Rd for qemu-devel@nongnu.org; Mon, 17 Feb 2020 13:40:50 -0500 Received: by mail-pg1-x544.google.com with SMTP id v23so6257841pgk.2 for ; Mon, 17 Feb 2020 10:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=asaUPZ/SSdNK/iGmvj3kmD3MIJpWIE5xkQPbCdtCCXY=; b=iiXTwH2ac7NFyGgBrotqJLwMlYa9zLCnkEbIecfue7dmdPkZ9obSDzUigLiSpFLKfz DYBg+NmlkiuplYbkQcHlWJKdl0HDxUGXH6e5tRkOtRYSh+z3HWnxmJWlgepr/ytqYx8g JietvKoDhBb5vtvgWFXVu4nNSjB/iDi05USunL+LR1jYZs+6s8tN+jSE4McEwobK12fB k5TW9VKbO+4XoJuJD4Owxy+jDwwHR4vnaav1xXZMVzlgyOFrmbXylohgjaw5YRO7lAHU k+Codv13+Pv56kBt+IzBXpQDJzgk8AvcTRxFrY86iwU8g793VJwZKiLpezfva30Buvz6 EDZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=asaUPZ/SSdNK/iGmvj3kmD3MIJpWIE5xkQPbCdtCCXY=; b=s+Bfa2f/Rgx6lGvuAoxw1r2QBpILpM7VarNkb9OFsFfCA+MuiafI0I86WQ9X/tvZWF PxzhOi4Goubw70jFEmFscxmdZjhR+oIf2Ucsl7ZPFCXuRaFlq8ef/+DIdJ3SNYYnaLAb NIHCfDSsd1IL4H634gHuXgIuTB1qkZVEqHaeOzxxPyGVpGtl0J6T4wUqnStFNtlaXSIB XoYJ3n8rSn7PimCECa+SpnJtWbbD0zS+Rih1TW+o1n95wBtmTCKuK5fDbdWBF9UyvpAW 6VOCXUaiyVeoFcFGuNHEgu9lXn8vLl4lRhMhwJAZh2hWAo91GtTXFT7B72MTOkOpN2tq U+0g== X-Gm-Message-State: APjAAAW7bXrE+o/Ak2e/tbEx1QTC29zFnm93S4xLPgolxUpQb3j/4XEt pRI6LO4DCdeysXts8/GMiyHc3Hese5o= X-Google-Smtp-Source: APXvYqzC8lslTx7aAzNyXLplumpzifFjWsTC5tSrPA4Xs3aM2pc7Y3LaUwgeBP1T8qQDx3P7ZSdInw== X-Received: by 2002:a63:fb05:: with SMTP id o5mr19505413pgh.355.1581964849835; Mon, 17 Feb 2020 10:40:49 -0800 (PST) Received: from [192.168.1.11] (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id q15sm1592202pgm.47.2020.02.17.10.40.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2020 10:40:49 -0800 (PST) Subject: Re: [PATCH v5 75/79] make mem_path local variable To: Igor Mammedov , qemu-devel@nongnu.org References: <20200217173452.15243-1-imammedo@redhat.com> <20200217173452.15243-76-imammedo@redhat.com> From: Richard Henderson Message-ID: <23f95d66-4cdd-8f7b-7213-8c2b6944bcfe@linaro.org> Date: Mon, 17 Feb 2020 10:40:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200217173452.15243-76-imammedo@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/17/20 9:34 AM, Igor Mammedov wrote: > It's no longer used anywhere beside main(), > so make it local variable that is used for CLI compat > purposes to keep -mem-path option working. > > Under hood QEMU will use it to create > memory-backend-file,mem-path=... > backend and use its MemoryRegion as main RAM. > > Signed-off-by: Igor Mammedov > --- > CC: pbonzini@redhat.com > --- > include/sysemu/sysemu.h | 1 - > vl.c | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~