qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Wu, Fei" <fei2.wu@intel.com>
To: Richard Henderson <richard.henderson@linaro.org>,
	<alex.bennee@linaro.org>, <qemu-devel@nongnu.org>
Cc: "Vanderson M. do Rosario" <vandersonmr2@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v14 05/10] debug: add -d tb_stats to control TBStatistics collection:
Date: Thu, 1 Jun 2023 14:59:34 +0800	[thread overview]
Message-ID: <23f9d94c-6c4f-d915-b1e4-c195404afe65@intel.com> (raw)
In-Reply-To: <4c32a2e4-1370-b81f-9fec-2603648c60c3@linaro.org>

On 6/1/2023 9:18 AM, Richard Henderson wrote:
> On 5/30/23 01:35, Fei Wu wrote:
>> From: "Vanderson M. do Rosario" <vandersonmr2@gmail.com>
>>
>>   -d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=<number>]]
>>
>> "dump_limit" is used to limit the number of dumped TBStats in
>> linux-user mode.
> 
> Why is user-mode special?
> 
Should be an issue in comment, not in code.

>>
>> [all+jit+exec+time] control the profilling level used
>> by the TBStats. Can be used as follow:
>>
>> -d tb_stats
>> -d tb_stats,level=jit+time
> 
> Comma is already used to separate different -d options.
> You should not overload that.
> 
> "level" doesn't make sense for things that aren't hierarchical.
> 
> What's wrong with tb-stats-{all,jit,time,exec}?
> 
Let me try.

Thanks,
Fei.
> 
> r~



  reply	other threads:[~2023-06-01  7:00 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30  8:35 [PATCH v14 00/10] TCG code quality tracking Fei Wu
2023-05-30  8:35 ` [PATCH v14 01/10] accel/tcg: remove CONFIG_PROFILER Fei Wu
2023-05-30  8:35 ` [PATCH v14 02/10] accel/tcg: introduce TBStatistics structure Fei Wu
2023-05-31 23:59   ` Richard Henderson
2023-06-01  1:30     ` Wu, Fei
2023-06-01  2:48       ` Richard Henderson
2023-06-01  0:01   ` Richard Henderson
2023-06-01  3:19     ` Wu, Fei
2023-06-01  4:16       ` Richard Henderson
2023-06-01  5:36         ` Wu, Fei
2023-05-30  8:35 ` [PATCH v14 03/10] accel: collecting TB execution count Fei Wu
2023-06-01  0:05   ` Richard Henderson
2023-06-01  5:44     ` Wu, Fei
2023-06-01 14:03       ` Richard Henderson
2023-06-02  1:54         ` Wu, Fei
2023-06-02  4:02           ` Richard Henderson
2023-05-30  8:35 ` [PATCH v14 04/10] accel/tcg: add jit stats and time to TBStatistics Fei Wu
2023-05-30  9:37   ` Markus Armbruster
2023-05-31  0:54     ` Wu, Fei
2023-06-01  1:08   ` Richard Henderson
2023-06-01  6:48     ` Wu, Fei
2023-06-01 14:10       ` Richard Henderson
2023-06-01 15:10       ` Richard Henderson
2023-05-30  8:35 ` [PATCH v14 05/10] debug: add -d tb_stats to control TBStatistics collection: Fei Wu
2023-06-01  1:18   ` Richard Henderson
2023-06-01  6:59     ` Wu, Fei [this message]
2023-05-30  8:35 ` [PATCH v14 06/10] monitor: adding tb_stats hmp command Fei Wu
2023-06-01  1:23   ` Richard Henderson
2023-06-01  7:20     ` Wu, Fei
2023-06-01 14:25       ` Richard Henderson
2023-05-30  8:35 ` [PATCH v14 07/10] tb-stats: reset the tracked TBs on a tb_flush Fei Wu
2023-06-01  1:30   ` Richard Henderson
2023-06-01  7:22     ` Wu, Fei
2023-05-30  8:35 ` [PATCH v14 08/10] Adding info [tb-list|tb] commands to HMP (WIP) Fei Wu
2023-06-01  2:40   ` Richard Henderson
2023-06-01 12:12     ` Wu, Fei
2023-06-06  7:30       ` Wu, Fei
2023-06-07 12:49     ` Wu, Fei
2023-06-08  7:38       ` Wu, Fei
2023-06-08  9:23         ` Peter Maydell
2023-06-08 12:06           ` Dr. David Alan Gilbert
2023-06-08 12:22             ` Peter Maydell
2023-06-09 14:32           ` Wu, Fei
2023-06-09 15:51             ` Peter Maydell
2023-06-12  1:20               ` Wu, Fei
2023-05-30  8:35 ` [PATCH v14 09/10] tb-stats: dump hot TBs at the end of the execution Fei Wu
2023-05-30  8:35 ` [PATCH v14 10/10] docs: add tb-stats how to Fei Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23f9d94c-6c4f-d915-b1e4-c195404afe65@intel.com \
    --to=fei2.wu@intel.com \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=vandersonmr2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).