* [Qemu-devel] [PATCH] net: Remove useless local var pkt
@ 2017-02-15 8:31 Fam Zheng
2017-02-15 8:58 ` Dmitry Fleytman
0 siblings, 1 reply; 3+ messages in thread
From: Fam Zheng @ 2017-02-15 8:31 UTC (permalink / raw)
To: qemu-devel; +Cc: Dmitry Fleytman, Jason Wang
This has been pointless since commit 605d52e62, which was a
search-and-replace, overlooked the redundancy.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/net/net_rx_pkt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c
index 1019b50..7f928d7 100644
--- a/hw/net/net_rx_pkt.c
+++ b/hw/net/net_rx_pkt.c
@@ -159,7 +159,6 @@ void net_rx_pkt_attach_iovec_ex(struct NetRxPkt *pkt,
void net_rx_pkt_dump(struct NetRxPkt *pkt)
{
#ifdef NET_RX_PKT_DEBUG
- NetRxPkt *pkt = (NetRxPkt *)pkt;
assert(pkt);
printf("RX PKT: tot_len: %d, vlan_stripped: %d, vlan_tag: %d\n",
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] net: Remove useless local var pkt
2017-02-15 8:31 [Qemu-devel] [PATCH] net: Remove useless local var pkt Fam Zheng
@ 2017-02-15 8:58 ` Dmitry Fleytman
2017-02-17 2:31 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Fleytman @ 2017-02-15 8:58 UTC (permalink / raw)
To: Fam Zheng; +Cc: Qemu Developers, Jason Wang
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
This patch also fixes compilation with NET_RX_PKT_DEBUG defined.
> On 15 Feb 2017, at 10:31 AM, Fam Zheng <famz@redhat.com> wrote:
>
> This has been pointless since commit 605d52e62, which was a
> search-and-replace, overlooked the redundancy.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/net/net_rx_pkt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c
> index 1019b50..7f928d7 100644
> --- a/hw/net/net_rx_pkt.c
> +++ b/hw/net/net_rx_pkt.c
> @@ -159,7 +159,6 @@ void net_rx_pkt_attach_iovec_ex(struct NetRxPkt *pkt,
> void net_rx_pkt_dump(struct NetRxPkt *pkt)
> {
> #ifdef NET_RX_PKT_DEBUG
> - NetRxPkt *pkt = (NetRxPkt *)pkt;
> assert(pkt);
>
> printf("RX PKT: tot_len: %d, vlan_stripped: %d, vlan_tag: %d\n",
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] net: Remove useless local var pkt
2017-02-15 8:58 ` Dmitry Fleytman
@ 2017-02-17 2:31 ` Jason Wang
0 siblings, 0 replies; 3+ messages in thread
From: Jason Wang @ 2017-02-17 2:31 UTC (permalink / raw)
To: Dmitry Fleytman, Fam Zheng; +Cc: Qemu Developers
On 2017年02月15日 16:58, Dmitry Fleytman wrote:
> Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
>
> This patch also fixes compilation with NET_RX_PKT_DEBUG defined.
>
>> On 15 Feb 2017, at 10:31 AM, Fam Zheng <famz@redhat.com> wrote:
>>
>> This has been pointless since commit 605d52e62, which was a
>> search-and-replace, overlooked the redundancy.
>>
>> Signed-off-by: Fam Zheng <famz@redhat.com>
>> ---
>> hw/net/net_rx_pkt.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/hw/net/net_rx_pkt.c b/hw/net/net_rx_pkt.c
>> index 1019b50..7f928d7 100644
>> --- a/hw/net/net_rx_pkt.c
>> +++ b/hw/net/net_rx_pkt.c
>> @@ -159,7 +159,6 @@ void net_rx_pkt_attach_iovec_ex(struct NetRxPkt *pkt,
>> void net_rx_pkt_dump(struct NetRxPkt *pkt)
>> {
>> #ifdef NET_RX_PKT_DEBUG
>> - NetRxPkt *pkt = (NetRxPkt *)pkt;
>> assert(pkt);
>>
>> printf("RX PKT: tot_len: %d, vlan_stripped: %d, vlan_tag: %d\n",
>> --
>> 2.9.3
>>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17 2:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-15 8:31 [Qemu-devel] [PATCH] net: Remove useless local var pkt Fam Zheng
2017-02-15 8:58 ` Dmitry Fleytman
2017-02-17 2:31 ` Jason Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).