qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Justin Terry (VM)" <juterry@microsoft.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "rth@twiddle.net" <rth@twiddle.net>,
	"ehabkost@redhat.com" <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits
Date: Tue, 19 Jun 2018 14:30:02 +0200	[thread overview]
Message-ID: <2413663f-b3c7-04cb-afb4-5d1b18147559@redhat.com> (raw)
In-Reply-To: <MW2PR2101MB09217AB059213F2EAE1C7B72B6710@MW2PR2101MB0921.namprd21.prod.outlook.com>

On 19/06/2018 00:01, Justin Terry (VM) wrote:
> The issue is that the Windows Hypervisor Platform will return #GP for
> any rdmsr/wrmsr that is not a virtualized MSR in the hypervisor by
> default. A virt stack (QEMU) can override this default behavior by
> registering for MSR exits. In this configuration the virt stack will
> receive any non-virtualized MSR exit and from the hypervisors
> perspective this is now effectively handled. I could certainly list
> each MSR individually but it seems overly prone to test-matrix
> errors. For example, each kernel that I try might succeed but a
> single option difference in another kernel might fail (which was the
> case here because the 4.4 kernel is different from the 4.14+ it
> seems). But, I will make any change you see fit to handle this in the
> way QEMU prefers.
> 
> As FYI, this is the same logic that Hyper-V uses in its virt stack
> for any hypervisor exits that are not handled in the hypervisor
> itself.

If by "the same logic" you mean that Hyper-V does
read-as-zero/write-to-nowhere, then the patch is okay with a comment
that says so.

Thanks,

Paolo

      reply	other threads:[~2018-06-19 12:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-05 22:15 [Qemu-devel] [PATCH 1/2] WHPX workaround bug in OSVW handling Justin Terry (VM)
2018-06-05 22:15 ` [Qemu-devel] [PATCH 2/2] WHPX: register for unrecognized MSR exits Justin Terry (VM)
2018-06-13 16:27   ` Paolo Bonzini
2018-06-18 22:01     ` Justin Terry (VM)
2018-06-19 12:30       ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2413663f-b3c7-04cb-afb4-5d1b18147559@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=juterry@microsoft.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).