* [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest
@ 2019-01-29 8:38 Philippe Mathieu-Daudé
2019-01-29 8:58 ` Thomas Huth
2019-01-29 9:11 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-29 8:38 UTC (permalink / raw)
To: qemu-devel
Cc: Michael S . Tsirkin, Thomas Huth, Laurent Vivier, Michael Roth,
Juan Quintela, Philippe Mathieu-Daudé
Due to a misuse of rules.mak logical functions, commit f386df17448
disabled the guest-agent test.
Enable it back.
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
>From rules.mak:
# Logical functions (for operating on y/n values like CONFIG_FOO vars)
# Usage: $(call land,$(CONFIG_FOO),$(CONFIG_BAR))
---
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.include b/tests/Makefile.include
index 19b4c0a696..172128b058 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -110,7 +110,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF)
check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF)
check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF)
ifneq (,$(findstring qemu-ga,$(TOOLS)))
-check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
+check-unit-$(call land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
endif
check-unit-y += tests/test-timed-average$(EXESUF)
check-unit-y += tests/test-util-sockets$(EXESUF)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest
2019-01-29 8:38 [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest Philippe Mathieu-Daudé
@ 2019-01-29 8:58 ` Thomas Huth
2019-01-29 9:11 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-01-29 8:58 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Michael S . Tsirkin, Laurent Vivier, Michael Roth, Juan Quintela
On 2019-01-29 09:38, Philippe Mathieu-Daudé wrote:
> Due to a misuse of rules.mak logical functions, commit f386df17448
> disabled the guest-agent test.
> Enable it back.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> From rules.mak:
>
> # Logical functions (for operating on y/n values like CONFIG_FOO vars)
> # Usage: $(call land,$(CONFIG_FOO),$(CONFIG_BAR))
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 19b4c0a696..172128b058 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -110,7 +110,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF)
> ifneq (,$(findstring qemu-ga,$(TOOLS)))
> -check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
> +check-unit-$(call land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
> endif
> check-unit-y += tests/test-timed-average$(EXESUF)
> check-unit-y += tests/test-util-sockets$(EXESUF)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest
2019-01-29 8:38 [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest Philippe Mathieu-Daudé
2019-01-29 8:58 ` Thomas Huth
@ 2019-01-29 9:11 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-01-29 9:11 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Michael S . Tsirkin, Thomas Huth, Michael Roth, Juan Quintela
On 29/01/2019 09:38, Philippe Mathieu-Daudé wrote:
> Due to a misuse of rules.mak logical functions, commit f386df17448
> disabled the guest-agent test.
> Enable it back.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> From rules.mak:
>
> # Logical functions (for operating on y/n values like CONFIG_FOO vars)
> # Usage: $(call land,$(CONFIG_FOO),$(CONFIG_BAR))
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 19b4c0a696..172128b058 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -110,7 +110,7 @@ check-unit-y += tests/test-crypto-secret$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlscredsx509$(EXESUF)
> check-unit-$(CONFIG_GNUTLS) += tests/test-crypto-tlssession$(EXESUF)
> ifneq (,$(findstring qemu-ga,$(TOOLS)))
> -check-unit-$(land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
> +check-unit-$(call land,$(CONFIG_LINUX),$(CONFIG_VIRTIO_SERIAL)) += tests/test-qga$(EXESUF)
> endif
> check-unit-y += tests/test-timed-average$(EXESUF)
> check-unit-y += tests/test-util-sockets$(EXESUF)
>
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-29 9:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-29 8:38 [Qemu-devel] [PATCH] tests/test-qga: Reenable guest-agent qtest Philippe Mathieu-Daudé
2019-01-29 8:58 ` Thomas Huth
2019-01-29 9:11 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).