From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,PDS_BAD_THREAD_QP_64, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 259C0C48BDF for ; Tue, 15 Jun 2021 23:36:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BAC0461245 for ; Tue, 15 Jun 2021 23:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAC0461245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ltIbG-0003PV-Cd for qemu-devel@archiver.kernel.org; Tue, 15 Jun 2021 19:36:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltIaI-0002ct-Vb for qemu-devel@nongnu.org; Tue, 15 Jun 2021 19:35:06 -0400 Received: from mga03.intel.com ([134.134.136.65]:10501) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltIaE-0008IY-Si for qemu-devel@nongnu.org; Tue, 15 Jun 2021 19:35:06 -0400 IronPort-SDR: v2N9UbHsFxwEjZSwx0rP8bqzMSWzqXspqUyyy9STk9X0ZSqDk0aGcUtxbNulREFkFWlrjHb7wq mtAJ6YLx7v/A== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="206122475" X-IronPort-AV: E=Sophos;i="5.83,276,1616482800"; d="scan'208";a="206122475" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2021 16:34:51 -0700 IronPort-SDR: OX0m688SOy8hM0QALSfRE0SNkPLuuXfyTXTInhqPi7jqfeZ49u4y4UkaSwYLaOw22W9F9F2DpE ru2Nb1uYT9ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,276,1616482800"; d="scan'208";a="404377392" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga003.jf.intel.com with ESMTP; 15 Jun 2021 16:34:51 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 15 Jun 2021 16:34:51 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Tue, 15 Jun 2021 16:34:50 -0700 Received: from orsmsx611.amr.corp.intel.com ([10.22.229.24]) by ORSMSX611.amr.corp.intel.com ([10.22.229.24]) with mapi id 15.01.2242.008; Tue, 15 Jun 2021 16:34:50 -0700 From: "Kasireddy, Vivek" To: Gerd Hoffmann Subject: RE: [PATCH v2 8/8] virtio-gpu: Add gl_flushed callback Thread-Topic: [PATCH v2 8/8] virtio-gpu: Add gl_flushed callback Thread-Index: AQHXXkyAAcqafR1P/UuqlBGOsdKVjKsVDW0AgACtc0A= Date: Tue, 15 Jun 2021 23:34:50 +0000 Message-ID: <2439020937f0488abc7b56a22945c1b3@intel.com> References: <20210610224837.670192-1-vivek.kasireddy@intel.com> <20210610224837.670192-9-vivek.kasireddy@intel.com> <20210615055026.m5az4qqmvh72iwbc@sirius.home.kraxel.org> In-Reply-To: <20210615055026.m5az4qqmvh72iwbc@sirius.home.kraxel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action x-originating-ip: [10.1.200.100] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Received-SPF: pass client-ip=134.134.136.65; envelope-from=vivek.kasireddy@intel.com; helo=mga03.intel.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "qemu-devel@nongnu.org" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Gerd, >=20 > > - if (!cmd->finished) { > > + if (!cmd->finished && !(cmd->cmd_hdr.flags & VIRTIO_GPU_FLAG_FENCE= )) { > > virtio_gpu_ctrl_response_nodata(g, cmd, cmd->error ? cmd->erro= r : > > VIRTIO_GPU_RESP_OK_NODATA); > > } >=20 > My idea would be more along the lines of ... >=20 > if (!cmd->finished) { > if (renderer_blocked) { > g->pending_completion =3D cmd; > } else { > virtio_gpu_ctrl_response_nodata(...) > } > } >=20 > Then, when resuming processing after unblock check pending_completion > and call virtio_gpu_ctrl_response_nodata if needed. >=20 > Workflow: >=20 > virtio_gpu_simple_process_cmd() > -> virtio_gpu_resource_flush() > -> dpy_gfx_update() > -> gd_gl_area_update() > call graphic_hw_gl_block(true), create fence. [Kasireddy, Vivek] So, with blobs, as you know we call dpy_gl_update() and = this call just "queues" the render/redraw. And, GTK then later calls the render signa= l callback=20 which in this case would be gd_gl_area_draw() which is where the actual Bli= t happens and also glFlush; only after which we can create a fence. > virtio_gpu_simple_process_cmd() > -> will see renderer_blocked and delays RESOURCE_FLUSH completion. >=20 > Then, when the fence is ready, gtk will: > - call graphic_hw_gl_block(false) > - call graphic_hw_gl_flush() > -> virtio-gpu resumes processing the cmd queue. [Kasireddy, Vivek] Yeah, I think this can be done. >=20 > When you use the existing block/unblock functionality the fence can be a > gtk internal detail, virtio-gpu doesn't need to know that gtk uses a > fence to wait for the moment when it can unblock virtio queue processing > (the egl fence helpers still make sense). [Kasireddy, Vivek] Ok, I'll try to include your suggestions in v3. Thanks, Vivek >=20 > take care, > Gerd