From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,
mreitz@redhat.com, stefanha@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] backup: allow target without .bdrv_get_info
Date: Tue, 14 Feb 2017 13:35:05 -0600 [thread overview]
Message-ID: <244acac1-4179-42d3-35c8-847539c2c244@redhat.com> (raw)
In-Reply-To: <20170214150539.GC20715@lemon.lan>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
On 02/14/2017 09:05 AM, Fam Zheng wrote:
>> Proposed NBD protocol extension - NBD_OPT_INFO should finally solve this problem.
>> But until it is not realized, we need allow backup to nbd target due to backward
>> compatibility.
>>
>> Furthermore, is it entirely ok to disallow backup if bds lacks .bdrv_get_info?
>> Which behavior should be default: to fail backup or to use default cluster size?
>>
>
> Target not having .bdrv_get_info means 'some sane assumptions are okay' to me, so
>
> Reviewed-by: Fam Zheng <famz@redhat.com>
>
> (But we are going to have a .bdrv_get_info after NBD_OPT_INFO, right?)
Yes. I'm reposting that series today.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-02-14 19:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 14:48 [Qemu-devel] [PATCH] backup: allow target without .bdrv_get_info Vladimir Sementsov-Ogievskiy
2017-02-14 15:05 ` Fam Zheng
2017-02-14 15:08 ` Denis V. Lunev
2017-02-14 19:35 ` Eric Blake [this message]
2017-02-14 17:18 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=244acac1-4179-42d3-35c8-847539c2c244@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).