* [PATCH] tcg/arm: Fix tcg_out_vec_op function signature
@ 2021-09-08 18:53 Jose R. Ziviani
2021-09-08 20:21 ` Philippe Mathieu-Daudé
2021-09-10 12:26 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Jose R. Ziviani @ 2021-09-08 18:53 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, qemu-arm, richard.henderson, Jose R. Ziviani
Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op
for arm is missing. It causes a build error on armv6 and armv7:
tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *'
{aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=]
const TCGArg *args, const int *const_args)
~~~~~~~~~~~~~~^~~~
../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]'
{aka 'const unsigned int[16]'}
const TCGArg args[TCG_MAX_OP_ARGS],
~~~~~~~~~~~~~~^~~~
Signed-off-by: Jose R. Ziviani <jziviani@suse.de>
---
tcg/arm/tcg-target.c.inc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
index 007ceee68e..e5b4f86841 100644
--- a/tcg/arm/tcg-target.c.inc
+++ b/tcg/arm/tcg-target.c.inc
@@ -2715,7 +2715,8 @@ static const ARMInsn vec_cmp0_insn[16] = {
static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc,
unsigned vecl, unsigned vece,
- const TCGArg *args, const int *const_args)
+ const TCGArg args[TCG_MAX_OP_ARGS],
+ const int const_args[TCG_MAX_OP_ARGS])
{
TCGType type = vecl + TCG_TYPE_V64;
unsigned q = vecl;
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tcg/arm: Fix tcg_out_vec_op function signature
2021-09-08 18:53 [PATCH] tcg/arm: Fix tcg_out_vec_op function signature Jose R. Ziviani
@ 2021-09-08 20:21 ` Philippe Mathieu-Daudé
2021-09-10 12:26 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-09-08 20:21 UTC (permalink / raw)
To: Jose R. Ziviani, qemu-devel, Miroslav Rezanina
Cc: qemu-trivial, qemu-arm, richard.henderson
On 9/8/21 8:53 PM, Jose R. Ziviani wrote:
> Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op
> for arm is missing. It causes a build error on armv6 and armv7:
>
> tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *'
> {aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=]
> const TCGArg *args, const int *const_args)
> ~~~~~~~~~~~~~~^~~~
> ../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]'
> {aka 'const unsigned int[16]'}
> const TCGArg args[TCG_MAX_OP_ARGS],
> ~~~~~~~~~~~~~~^~~~
>
> Signed-off-by: Jose R. Ziviani <jziviani@suse.de>
> ---
> tcg/arm/tcg-target.c.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tcg/arm/tcg-target.c.inc b/tcg/arm/tcg-target.c.inc
> index 007ceee68e..e5b4f86841 100644
> --- a/tcg/arm/tcg-target.c.inc
> +++ b/tcg/arm/tcg-target.c.inc
> @@ -2715,7 +2715,8 @@ static const ARMInsn vec_cmp0_insn[16] = {
>
> static void tcg_out_vec_op(TCGContext *s, TCGOpcode opc,
> unsigned vecl, unsigned vece,
> - const TCGArg *args, const int *const_args)
> + const TCGArg args[TCG_MAX_OP_ARGS],
> + const int const_args[TCG_MAX_OP_ARGS])
> {
> TCGType type = vecl + TCG_TYPE_V64;
> unsigned q = vecl;
>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tcg/arm: Fix tcg_out_vec_op function signature
2021-09-08 18:53 [PATCH] tcg/arm: Fix tcg_out_vec_op function signature Jose R. Ziviani
2021-09-08 20:21 ` Philippe Mathieu-Daudé
@ 2021-09-10 12:26 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2021-09-10 12:26 UTC (permalink / raw)
To: Jose R. Ziviani, qemu-devel; +Cc: qemu-trivial, qemu-arm
On 9/8/21 8:53 PM, Jose R. Ziviani wrote:
> Commit 5e8892db93 fixed several function signatures but tcg_out_vec_op
> for arm is missing. It causes a build error on armv6 and armv7:
>
> tcg-target.c.inc:2718:42: error: argument 5 of type 'const TCGArg *'
> {aka 'const unsigned int *'} declared as a pointer [-Werror=array-parameter=]
> const TCGArg *args, const int *const_args)
> ~~~~~~~~~~~~~~^~~~
> ../tcg/tcg.c:120:41: note: previously declared as an array 'const TCGArg[16]'
> {aka 'const unsigned int[16]'}
> const TCGArg args[TCG_MAX_OP_ARGS],
> ~~~~~~~~~~~~~~^~~~
>
> Signed-off-by: Jose R. Ziviani<jziviani@suse.de>
> ---
> tcg/arm/tcg-target.c.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Queued, thanks.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-10 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-08 18:53 [PATCH] tcg/arm: Fix tcg_out_vec_op function signature Jose R. Ziviani
2021-09-08 20:21 ` Philippe Mathieu-Daudé
2021-09-10 12:26 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).