qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Jonathan Cameron" <jonathan.cameron@huawei.com>,
	"Fan Ni" <fan.ni@samsung.com>,
	"John Levon" <john.levon@nutanix.com>,
	"Thanos Makatos" <thanos.makatos@nutanix.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Alex Williamson" <alex@shazbot.org>
Subject: Re: [PATCH 3/9] scripts/clean-includes: Make ignore-regexes one per line
Date: Mon, 17 Nov 2025 10:19:57 +0100	[thread overview]
Message-ID: <245a1415-1493-4202-838f-e13c3882eff2@linaro.org> (raw)
In-Reply-To: <20251104160943.751997-4-peter.maydell@linaro.org>

On 11/4/25 17:09, Peter Maydell wrote:
> Currently we have a single extended regular expression defining
> files that clean-includes should ignore. This is now very long
> and awkward to read and edit.
> 
> Switch to having a list of newline-separated EREs that we write
> to a file for grep's -f option, so we can express them more
> legibly in the shell script. We allow for comments in the
> regex list, which lets us document why we have put the
> exclusions in.
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   scripts/clean-includes | 28 ++++++++++++++++++++++------
>   1 file changed, 22 insertions(+), 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2025-11-17  9:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 16:09 [PATCH 0/9] clean-includes: improve exclude list, run on cxl, vfio, tests Peter Maydell
2025-11-04 16:09 ` [PATCH 1/9] scripts/clean-includes: Allow directories on command line Peter Maydell
2025-11-17  9:16   ` Richard Henderson
2025-11-04 16:09 ` [PATCH 2/9] scripts/clean-includes: Remove outdated comment Peter Maydell
2025-11-17  9:17   ` Richard Henderson
2025-11-04 16:09 ` [PATCH 3/9] scripts/clean-includes: Make ignore-regexes one per line Peter Maydell
2025-11-17  9:19   ` Richard Henderson [this message]
2025-11-04 16:09 ` [PATCH 4/9] scripts/clean-includes: Do all our exclusions with REGEXFILE Peter Maydell
2025-11-17  9:21   ` Richard Henderson
2025-11-04 16:09 ` [PATCH 5/9] scripts/clean-includes: Give the args in git commit messages Peter Maydell
2025-11-07 12:05   ` Markus Armbruster
2025-11-07 13:14     ` Peter Maydell
2025-11-07 13:44       ` Markus Armbruster
2025-11-07 15:42         ` Markus Armbruster
2025-11-04 16:09 ` [PATCH 6/9] scripts/clean-includes: Update exclude list Peter Maydell
2025-11-17  9:33   ` Richard Henderson
2025-11-04 16:09 ` [PATCH 7/9] cxl: Clean up includes Peter Maydell
2025-11-04 16:51   ` Philippe Mathieu-Daudé
2025-11-04 16:54   ` Jonathan Cameron via
2025-11-17  9:34   ` Richard Henderson
2025-11-04 16:09 ` [PATCH 8/9] vfio: " Peter Maydell
2025-11-04 16:40   ` Cédric Le Goater
2025-11-04 16:51   ` Philippe Mathieu-Daudé
2025-11-04 16:09 ` [PATCH 9/9] tests: " Peter Maydell
2025-11-04 16:48   ` Cédric Le Goater
2025-11-14 13:19 ` [PATCH 0/9] clean-includes: improve exclude list, run on cxl, vfio, tests Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=245a1415-1493-4202-838f-e13c3882eff2@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex@shazbot.org \
    --cc=clg@redhat.com \
    --cc=fan.ni@samsung.com \
    --cc=john.levon@nutanix.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thanos.makatos@nutanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).