qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Eric Blake" <eblake@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"P. Berrange, Daniel" <berrange@redhat.com>,
	"Armbruster, Markus" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qobject: assume base of a qobject is at offset 0
Date: Wed, 21 Mar 2018 15:49:13 +0100	[thread overview]
Message-ID: <2467bc3b-c0da-b6e4-1201-48983ba5a5af@redhat.com> (raw)
In-Reply-To: <CAMxuvay+aMU7=kr2ED+7Hq596oeoZP+xKXMYwGB+r8AG5=5rdQ@mail.gmail.com>

On 21/03/2018 15:21, Marc-André Lureau wrote:
>>> Yeah, I tried a few of those approaches. Here the problem is that
>>> QObject doesn't have base field. So you get a compile time error with
>>> a QObject * as argument.
>>
>> So the compiler requires &(x)->base to resolve even when it is not on the
>> branch that gets selected?
> 
> Unfortunately, yes, all branches must compile apparently (I know)...

Ugh, and that's indeed true of _Generic too.  These don't compile:

  struct s1 { int y; };
  struct s2 { int z; };

  #define f(x)  _Generic(x, struct s1: (x).y, struct s2: (x).z)

  int f1(struct s1 *s) { return f(*s); }
  int f2(struct s2 *s) { return f(*s); }

:(  Then I guess Marc-André's realization is ugly but unavoidable.

Paolo

  reply	other threads:[~2018-03-21 14:49 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-21 13:40 [Qemu-devel] [PATCH 0/3] RFC: simplify qobject refcount Marc-André Lureau
2018-03-21 13:40 ` [Qemu-devel] [PATCH 1/3] compiler: extend QEMU_GENERIC to handle more arguments Marc-André Lureau
2018-03-21 13:40 ` [Qemu-devel] [PATCH 2/3] qobject: assume base of a qobject is at offset 0 Marc-André Lureau
2018-03-21 14:01   ` Paolo Bonzini
2018-03-21 14:08     ` Marc-André Lureau
2018-03-21 14:19       ` Eric Blake
2018-03-21 14:21         ` Marc-André Lureau
2018-03-21 14:49           ` Paolo Bonzini [this message]
2018-03-21 15:29             ` Eric Blake
2018-03-21 15:34               ` Paolo Bonzini
2018-03-21 15:55     ` Marc-André Lureau
2018-03-21 16:00       ` Paolo Bonzini
2018-03-21 16:11         ` Marc-André Lureau
2018-03-21 16:23           ` Paolo Bonzini
2018-03-21 16:59             ` Marc-André Lureau
2018-03-21 17:08               ` Eric Blake
2018-03-21 17:23                 ` Marc-André Lureau
2018-03-21 17:38                   ` Eric Blake
2018-03-21 17:43                   ` Paolo Bonzini
2018-03-21 14:01   ` Eric Blake
2018-03-21 14:02     ` Paolo Bonzini
2018-03-21 13:40 ` [Qemu-devel] [PATCH 3/3] qobject: replace qobject_incref/QINCREF qobject_decref/QDECREF Marc-André Lureau
2018-03-21 14:28   ` Eric Blake
2018-03-21 14:51     ` Marc-André Lureau
2018-03-21 15:36       ` Eric Blake
2018-03-21 14:09 ` [Qemu-devel] [PATCH 0/3] RFC: simplify qobject refcount Eric Blake
2018-03-21 14:19   ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2467bc3b-c0da-b6e4-1201-48983ba5a5af@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).