qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Yi Wang <wang.yi59@zte.com.cn>, qemu-devel@nongnu.org
Cc: wang.liang82@zte.com.cn, Juan Quintela <quintela@redhat.com>,
	QEMU Trivial <qemu-trivial@nongnu.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	xue.zhihong@zte.com.cn, Liao Pingfang <liao.pingfang@zte.com.cn>
Subject: Re: [PATCH 06/12] migration/migration.c: Remove superfluous breaks
Date: Mon, 13 Jul 2020 11:34:37 +0200	[thread overview]
Message-ID: <246b77fd-00d9-4299-203c-0657c184e5de@redhat.com> (raw)
In-Reply-To: <1594631078-36453-1-git-send-email-wang.yi59@zte.com.cn>

On 13/07/2020 11.04, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove superfluous breaks, as there is a "return" before them.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  migration/migration.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 92e44e0..2fd5fbb 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -985,7 +985,6 @@ static void fill_source_migration_info(MigrationInfo *info)
>          /* no migration has happened ever */
>          /* do not overwrite destination migration status */
>          return;
> -        break;
>      case MIGRATION_STATUS_SETUP:
>          info->has_status = true;
>          info->has_total_time = false;
> @@ -1104,7 +1103,6 @@ static void fill_destination_migration_info(MigrationInfo *info)
>      switch (mis->state) {
>      case MIGRATION_STATUS_NONE:
>          return;
> -        break;
>      case MIGRATION_STATUS_SETUP:
>      case MIGRATION_STATUS_CANCELLING:
>      case MIGRATION_STATUS_CANCELLED:
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>



      reply	other threads:[~2020-07-13  9:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13  9:04 [PATCH 06/12] migration/migration.c: Remove superfluous breaks Yi Wang
2020-07-13  9:34 ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=246b77fd-00d9-4299-203c-0657c184e5de@redhat.com \
    --to=thuth@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=liao.pingfang@zte.com.cn \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=wang.liang82@zte.com.cn \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).