Re: [Qemu-devel] Preconfig state reachable without --preconfig given

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1526 bytes --]

On 2018-06-02 12:46, Michal Privoznik wrote:
> On 06/01/2018 03:28 PM, Max Reitz wrote:
>> Hi,
>>
>> The @preconfig RunState documentation states:
>>
>>> The state is reachable only if the --preconfig CLI option is used.
>>
>> However, this is not true:
>>
>> $ echo | x86_64-softmmu/qemu-system-x86_64 -monitor stdio
>> QEMU 2.12.50 monitor - type 'help' for more information
>> (qemu)
>> HMP not available in preconfig state, use QMP instead
> 
> Not sure if this is the same bug, but I've noticed libvirt having
> troubles detecting capabilities of qemu and debugging lead to this patch:
> 
> http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg00367.html
> 
> (which by no means I claim is proper solution. It might be viewed as
> workaround by expert qemu devels)

Well, it'd fix both of my issues, so it has that going for it. :-)

>> On IRC, Daniel proposed doing the runstate transition immediately after
>> the command line has been read and no --preconfig option has been found.
>>  Doing that indeed fixes the issue for me (but I don't know whether
>> that's the best solution).
> 
> Oh has he? I can't find it anywhere.

That was in #qemu on OFTC:

[Friday, June 1 2018] [15:21:26 CEST] <danpb> if we've not passed
--preconfig though, we should not be in PRECONFIG state in the first
place IMHO
[Friday, June 1 2018] [15:22:27 CEST] <danpb> eg  vl.c should set the
state to RUN_STATE_PRELAUNCH  immediately after parsing CLI args if
--preconfig wasn't given

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]