From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fIKYJ-00064p-Rf for qemu-devel@nongnu.org; Mon, 14 May 2018 16:58:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fIKYJ-0003YH-5H for qemu-devel@nongnu.org; Mon, 14 May 2018 16:58:39 -0400 References: <20180509162637.15575-1-kwolf@redhat.com> <20180509162637.15575-14-kwolf@redhat.com> From: John Snow Message-ID: <2480e21a-21ae-fbc9-1b0b-4f38bb889e25@redhat.com> Date: Mon, 14 May 2018 16:58:31 -0400 MIME-Version: 1.0 In-Reply-To: <20180509162637.15575-14-kwolf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 13/42] job: Move state transitions to Job List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, jcody@redhat.com, armbru@redhat.com, mreitz@redhat.com On 05/09/2018 12:26 PM, Kevin Wolf wrote: > This moves BlockJob.status and the closely related functions > (block_)job_state_transition() and (block_)job_apply_verb to Job. The > two QAPI enums are renamed to JobStatus and JobVerb. > > Signed-off-by: Kevin Wolf In good faith that the TODOs dissolve by the end of the series: Reviewed-by: John Snow (As a bonus, removing 'BLOCK' out of all of those enum names made the table a little thinner column-wise. nice!)