qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Cédric Le Goater" <clg@redhat.com>,
	"QEMU Trivial" <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] kconfig: Add NVME to s390x machines
Date: Mon, 28 Aug 2023 20:16:02 +0200	[thread overview]
Message-ID: <24997879-0596-94e0-7f1d-f5eea18fea09@redhat.com> (raw)
In-Reply-To: <20230828150148.120031-1-clg@kaod.org>

On 28/08/2023 17.01, Cédric Le Goater wrote:
> From: Cédric Le Goater <clg@redhat.com>
> 
> We recently had issues with nvme devices on big endian platforms.
> Include their compilation on s390x to ease tests.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   hw/nvme/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/nvme/Kconfig b/hw/nvme/Kconfig
> index 8ac90942e55e..cfa2ab0f9d5a 100644
> --- a/hw/nvme/Kconfig
> +++ b/hw/nvme/Kconfig
> @@ -1,4 +1,4 @@
>   config NVME_PCI
>       bool
> -    default y if PCI_DEVICES
> +    default y if PCI_DEVICES || PCIE_DEVICES
>       depends on PCI

hw/nvme/ctrl.c uses INTERFACE_PCIE_DEVICE, so I think looks right to me.

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2023-08-28 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 15:01 [PATCH] kconfig: Add NVME to s390x machines Cédric Le Goater
2023-08-28 18:16 ` Thomas Huth [this message]
2023-08-30  6:56 ` Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24997879-0596-94e0-7f1d-f5eea18fea09@redhat.com \
    --to=thuth@redhat.com \
    --cc=clg@kaod.org \
    --cc=clg@redhat.com \
    --cc=its@irrelevant.dk \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).