From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Juan Quintela <quintela@redhat.com>,
lvivier@redhat.com, qemu-devel@nongnu.org, peterx@redhat.com,
dgilbert@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability
Date: Tue, 16 May 2017 11:48:01 -0500 [thread overview]
Message-ID: <24a363d9-a395-325c-ff6c-f79211c773fb@redhat.com> (raw)
In-Reply-To: <87k25g92i8.fsf@dusky.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 967 bytes --]
On 05/16/2017 11:42 AM, Markus Armbruster wrote:
>>> Well, to suggest something, I'd first have to figure out WTF incremental
>>> block migration does. Your text helps me some, but not enough. What
>>> exactly is being migrated, and what exactly is assumed to be shared
>>> between source and destination?
>>>
>>> Block migration is scandalously underdocumented.
>>
> Can you draft a documentation comment for @block-incremental?
How about:
@block-incremental: Affects how much storage is migrated when the block
migration capability is enabled. When false, the entire storage backing
chain is migrated into a flattened image at the destination; when true,
only the active qcow2 layer is migrated and the destination must already
have access to the same backing chain as was used on the source.
(since 2.10)
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2017-05-16 16:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 11:11 [Qemu-devel] [PATCH v4 0/5] Remove old MigrationParams Juan Quintela
2017-05-16 11:11 ` [Qemu-devel] [PATCH 1/5] hmp: Use visitor api for hmp_migrate_set_parameter() Juan Quintela
2017-05-16 12:29 ` Markus Armbruster
2017-05-16 11:11 ` [Qemu-devel] [PATCH 2/5] migration: Create block capability Juan Quintela
2017-05-16 14:20 ` Markus Armbruster
2017-05-16 14:34 ` Juan Quintela
2017-05-16 16:00 ` Markus Armbruster
2017-05-16 16:08 ` Eric Blake
2017-05-16 16:42 ` Markus Armbruster
2017-05-16 16:48 ` Eric Blake [this message]
2017-05-16 17:07 ` Markus Armbruster
2017-05-16 17:37 ` Juan Quintela
2017-05-16 11:11 ` [Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams Juan Quintela
2017-05-16 14:22 ` Markus Armbruster
2017-05-16 14:36 ` Juan Quintela
2017-05-16 15:35 ` Markus Armbruster
2017-05-16 11:11 ` [Qemu-devel] [PATCH 4/5] migration: Remove " Juan Quintela
2017-05-16 11:11 ` [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable Juan Quintela
-- strict thread matches above, loose matches on Subject: below --
2017-05-17 15:38 [Qemu-devel] [PATCH v5 0/5] Remove old MigrationParams Juan Quintela
2017-05-17 15:38 ` [Qemu-devel] [PATCH 2/5] migration: Create block capability Juan Quintela
2017-05-17 15:52 ` Eric Blake
2017-05-17 17:02 ` Juan Quintela
2017-05-18 11:18 [Qemu-devel] [PATCH 0/5] Remove old MigrationParams Juan Quintela
2017-05-18 11:18 ` [Qemu-devel] [PATCH 2/5] migration: Create block capability Juan Quintela
2017-05-18 14:49 ` Eric Blake
2017-05-19 9:20 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a363d9-a395-325c-ff6c-f79211c773fb@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).