From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE2BAC25B75 for ; Mon, 3 Jun 2024 05:44:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sE0Uh-0007EE-Hu; Mon, 03 Jun 2024 01:44:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sE0Ug-0007E2-1Y for qemu-devel@nongnu.org; Mon, 03 Jun 2024 01:44:30 -0400 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sE0Ud-0004Yb-SR for qemu-devel@nongnu.org; Mon, 03 Jun 2024 01:44:29 -0400 Received: by mail-pj1-x1033.google.com with SMTP id 98e67ed59e1d1-2c1def9b4b3so1818656a91.0 for ; Sun, 02 Jun 2024 22:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1717393466; x=1717998266; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bFX017E7vF54R9D7CK5reHQUfuOV+AkSJzQ84FLY+/M=; b=LC3NJJawndKg7IzZCP5dG726NPorIKiAOxdwC7evrmmfqEWXKUfFnDlLTX5G9aYeG4 R9zKvB1NoTyTnjsgVWPNGhwlOR37Z3+faWcWUhkIciS56Ocl0pLL5qiz88+5VyKQqh5/ cVGtey44qF024jvOHPwhiiDrhn3vKZLscz9pJcsMXEUnfz57Yg7LidDtxvxzZqhnp4s9 uVrYCSnNaHPpFAXhzgrRxUvozR2Uub8DqYY63HvXGYN0z5Pkgl9tzu+tI3uBcwx5LK1e +/HWyq+a4WPVvocx08EQU8TwEJ4lL8J6xLIHw5o2DxLa4dKLmWg2whevHX7aHdkm2v4f hitg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717393466; x=1717998266; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bFX017E7vF54R9D7CK5reHQUfuOV+AkSJzQ84FLY+/M=; b=pEKcdlG9GRX+wh3AsnM5KrpMY8xx52Qnuflq52JvhfRULh3xdWVZLJEEQ2u2dv3tiH gKglqrmThRjNiiHUHDQ4bB1p83qIYlbyn/fV5ZTz9Ai40pLXPPn+N/qsnSuMtESi0N6A XKGlExD5DITGJbx4iNNfpnbnop7QbUloTfsEnwaebScmN6RcN9NsnZgoYgnqIQlyL2qw u9cIb4LevECZEFC5sUdzXfhEMxbJQIahZMblJ1gKq2HY04zBGip0HmCP9EFvAObR+WEy mo1FpINJGJpLWZ2R061dgGURdu0/rF8WGXjmTBRaJR41lPDRLbA0qTRqUO33baoOtRVP oIaA== X-Gm-Message-State: AOJu0Yzg5RoTpNXXQ8/eVSp+ITRKvWtHS9bXscCind5674oJIyNnQSNr pU67xiwztwzmswycDNOIvVhhJFeUC40ao/3vFOVVR84KKmT+LiHbYsIQPABu+hA= X-Google-Smtp-Source: AGHT+IEs7EyVCzLMiAwjAMip/wQx8mdBaUuMoZBzOeJMuT4rb5edsJ45e4lGTGKWoQEyHZwPTmbs9A== X-Received: by 2002:a17:90a:fd8e:b0:2bd:f712:48c5 with SMTP id 98e67ed59e1d1-2c1dc5dd5dfmr6486274a91.49.1717393466376; Sun, 02 Jun 2024 22:44:26 -0700 (PDT) Received: from [157.82.204.135] ([157.82.204.135]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c1a778361csm7044335a91.34.2024.06.02.22.44.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Jun 2024 22:44:26 -0700 (PDT) Message-ID: <24afb7f8-f091-4405-917e-ee7bb0a1e2b8@daynix.com> Date: Mon, 3 Jun 2024 14:44:19 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 03/13] virtio-gpu: Handle virtio_gpu_virgl_init() failure To: Dmitry Osipenko , Huang Rui , =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann , "Michael S . Tsirkin" , Stefano Stabellini , Antonio Caggiano , "Dr . David Alan Gilbert" , Robert Beckett , Gert Wollny , =?UTF-8?Q?Alex_Benn=C3=A9e?= Cc: qemu-devel@nongnu.org, Gurchetan Singh , ernunes@redhat.com, Alyssa Ross , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?Q?Christian_K=C3=B6nig?= , Xenia Ragiadakou , Pierre-Eric Pelloux-Prayer , Honglei Huang , Julia Zhang , Chen Jiqian , Yiwei Zhang References: <20240527030233.3775514-1-dmitry.osipenko@collabora.com> <20240527030233.3775514-4-dmitry.osipenko@collabora.com> Content-Language: en-US From: Akihiko Odaki In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=2607:f8b0:4864:20::1033; envelope-from=akihiko.odaki@daynix.com; helo=mail-pj1-x1033.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2024/06/03 14:26, Dmitry Osipenko wrote: > On 6/2/24 08:34, Akihiko Odaki wrote: >>> +typedef enum { >>> +    RS_START,       /* starting state */ >>> +    RS_INIT_FAILED, /* failed initialisation */ >> >> Is the distinction between RS_START and RS_INIT_FAILED really necessary? > > The state stays in RS_INIT_FAILED once was failed until virtio-gpu is > reset, re-initializing virglrenderer isn't allowed in this state. Can you elaborate more? Why isn't re-initializing allowed?