Re: [PATCH 4/5] target/loongarch: Set function loongarch_map_address() with common code

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 14/4/25 03:25, Bibo Mao wrote:
> Function loongarch_map_address is to get physical address from virtual
> address, it is used by qmp commands to dump memeory from virtual

Typo "memory",

> address.
> 
> It is used by kvm mode also, here move function loongarch_map_address()
> out of macro CONFIG_TCG. And it is common code, the similiar with

"similar".

> function loongarch_page_table_walker().
> 
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
>   target/loongarch/cpu_helper.c | 17 ++++++++---------
>   1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/target/loongarch/cpu_helper.c b/target/loongarch/cpu_helper.c
> index 6736a9a330..7a56482282 100644
> --- a/target/loongarch/cpu_helper.c
> +++ b/target/loongarch/cpu_helper.c
> @@ -155,6 +155,14 @@ static int loongarch_get_addr_from_tlb(CPULoongArchState *env, hwaddr *physical,
>   
>       return TLBRET_NOMATCH;
>   }
> +#else
> +static int loongarch_get_addr_from_tlb(CPULoongArchState *env, hwaddr *physical,
> +                                       int *prot, target_ulong address,
> +                                       MMUAccessType access_type, int mmu_idx)
> +{
> +    return TLBRET_NOMATCH;
> +}
> +#endif
>   
>   void get_dir_base_width(CPULoongArchState *env, uint64_t *dir_base,
>                           uint64_t *dir_width, target_ulong level)
> @@ -283,15 +291,6 @@ static int loongarch_map_address(CPULoongArchState *env, hwaddr *physical,
>   
>       return TLBRET_NOMATCH;
>   }
> -#else
> -static int loongarch_map_address(CPULoongArchState *env, hwaddr *physical,
> -                                 int *prot, target_ulong address,
> -                                 MMUAccessType access_type, int mmu_idx,
> -                                 int is_debug)
> -{
> -    return TLBRET_NOMATCH;
> -}
> -#endif

The change seems incomplete but fixed in the next patch. Maybe rebase issue?