Re: [PATCH] qemu-nbd: Removed deprecated --partition option

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]

On 23.01.20 13:30, Eric Blake wrote:
> On 1/23/20 6:10 AM, Max Reitz wrote:
>> On 22.01.20 22:43, Eric Blake wrote:
>>> The option was deprecated in 4.0.0 (commit 0ae2d546); it's now been
>>> long enough with no complaints to follow through with that process.
>>>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>> ---
> 
>>> -@code{qemu-nbd -t -P 1 -f qcow2 file.qcow2}
>>> -
>>> -can be rewritten as:
>>> -
>>> -@code{qemu-nbd -t --image-opts
>>> driver=raw,offset=1M,size=100M,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file.qcow2}
>>>
>>> -
> 
>>> +can be rewritten as:
>>> +
>>> +@code{qemu-nbd -t --image-opts
>>> driver=raw,offset=1M,size=100M,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file.qcow2}
>>>
>>
>> I know you just moved it from above, but isn’t this wrong?  Shouldn’t it
>> be s/backing/file/g?
> 
> Indeed; file.file.driver=file,file.file.filename=file.qcow2 is required
> for it to work, rather than fail with
> qemu-nbd: Failed to blk_new_open
> 'driver=raw,offset=1m,size=100m,file.driver=qcow2,file.backing.driver=file,file.backing.filename=file4':
> A block device must be specified for "file"
> 
> I'll repost with the bug-fix as a separate commit (and it's a shame that
> we've gone nearly a year with no one noticing the typo in the original).

It was actually meant as a service to our users!  So they can’t just
blindly copy-paste the example but have to think it through.  And the
fact that noone has complained shows that our users indeed didn’t let
themselves be caught off-guard!  /s O:-)

Thanks!

Max


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]