From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzP1Y-0004Vt-NF for qemu-devel@nongnu.org; Wed, 26 Oct 2016 10:17:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzP1X-0007DD-Kp for qemu-devel@nongnu.org; Wed, 26 Oct 2016 10:17:48 -0400 References: <20161025131141.24762-1-mreitz@redhat.com> <20161025131141.24762-9-mreitz@redhat.com> From: Max Reitz Message-ID: <24d152ed-e18d-c736-f798-0d050a58ff55@redhat.com> Date: Wed, 26 Oct 2016 16:17:37 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MKgPmX7LhiqrjgtwqC23mcIJDJfojvDUi" Subject: Re: [Qemu-devel] [PATCH v5 08/13] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini , Markus Armbruster This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MKgPmX7LhiqrjgtwqC23mcIJDJfojvDUi From: Max Reitz To: Eric Blake , qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Kevin Wolf , Paolo Bonzini , Markus Armbruster Message-ID: <24d152ed-e18d-c736-f798-0d050a58ff55@redhat.com> Subject: Re: [PATCH v5 08/13] qapi: Allow blockdev-add for NBD References: <20161025131141.24762-1-mreitz@redhat.com> <20161025131141.24762-9-mreitz@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 26.10.2016 01:57, Eric Blake wrote: > On 10/25/2016 08:11 AM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> qapi/block-core.json | 25 ++++++++++++++++++++++--- >> 1 file changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/qapi/block-core.json b/qapi/block-core.json >> index 97b1205..4b4a74c 100644 >> --- a/qapi/block-core.json >> +++ b/qapi/block-core.json >> @@ -1703,14 +1703,15 @@ >> # >> # @host_device, @host_cdrom: Since 2.1 >> # @gluster: Since 2.7 >> +# @nbd: Since 2.8 >=20 > 'replication' was also added in 2.8; we should mention it while touchin= g > this. >=20 >> # >> # Since: 2.0 >> ## >> { 'enum': 'BlockdevDriver', >> 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',= >> 'dmg', 'file', 'ftp', 'ftps', 'gluster', 'host_cdrom', >> - 'host_device', 'http', 'https', 'luks', 'null-aio', 'null= -co', >> - 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', >> + 'host_device', 'http', 'https', 'luks', 'nbd', 'null-aio'= , >> + 'null-co', 'parallels', 'qcow', 'qcow2', 'qed', 'quorum',= 'raw', >> 'replication', 'tftp', 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] }= >=20 > Can we fix the TAB damage while at it? >=20 > Reviewed-by: Eric Blake You're completely right with both comments, but I think putting them in separate patches might be better (we even have time after soft freeze for this). If the maintainer applying this patch decides to put the tab fix into this patch while applying, I wouldn't mind, though. Max --MKgPmX7LhiqrjgtwqC23mcIJDJfojvDUi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEvBAEBCAAZBQJYELsBEhxtcmVpdHpAcmVkaGF0LmNvbQAKCRD0B9sAYdXPQOMr CAC4zfmfCU9l6Z/BkZ/kylSmnYaJhhKxnqNTQRt7hCj6gnzWrXb9azKg90WI5aDB F9eapbpcfi2WOzXcaOqwnIzG+I4euTbgA3YocCmEQUozBDV2ycOGyEHg7REVCnXi MAnlEFU6NZTaNAe6WC5VwLm6UBeZX57W+Jlr0ML1jWWDMvZZw1J2Vqb5HWBVr/Si GtF7Ey5ZiIiuGuG8pNw+AVD/8fUK5QnW/Ji7efafgiC6R7XFJ7IyrrVwrzCnhJbo BgGceZPY6F4df5J3l7TsVz1D1nc/+q4nZQxs7w7EVFcHPjzZiqgdOwPjsj15MsyS eoBK4rZXFzcZEU2jx+ioyHNX =LO3R -----END PGP SIGNATURE----- --MKgPmX7LhiqrjgtwqC23mcIJDJfojvDUi--