qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alexander Graf" <agraf@suse.de>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [Qemu-devel] handling emulation fine-grained memory protection
Date: Mon, 3 Jul 2017 09:07:32 -0700	[thread overview]
Message-ID: <24d9856c-dd4e-70d1-5eaf-3f36e70fad72@twiddle.net> (raw)
In-Reply-To: <CAFEAcA_OcQY1V16Vi8Ld1iZprPUsq+OCML0udYzLhVToCUXt_g@mail.gmail.com>

On 07/03/2017 03:04 AM, Peter Maydell wrote:
> For the ARM v7M microcontrollers we currently treat their memory
> protection unit like a funny kind of MMU that only has a 1:1
> address mapping. This basically works but it means that we can
> only support protection regions which are a multiple of 1K in
> size and on a 1K address boundary (because that's what we define
> as the "page size" for it). The real hardware lets you define
> protection regions on a granularity down to 64 bytes (both size
> and address).
> 
> So far we've got away with this, but I think only because the
> payloads we've tested haven't really used the MPU much or at all.
> With v8M I expect the MPU (and its secure/non-secure cousin the
> Security Attribution Unit) to be much more heavily used, so it
> would be nice if we could lift this limitation somehow.
> 
> Does anybody have any good ideas for how this ought to be done?
> We could wind down the "page size" for these CPUs (since we
> now have runtime-configurable-page-size for ARM CPUs this
> shouldn't compromise the A profile cores which can stick to
> 1K or 4K pages) but I don't think we can get down as low as
> 64 bytes due to all the things we keep in the low bits of
> TLB entries.

It's close..  We need 3 bits that do not overlap any requested alignment.

Does the v7m profile have 8-byte aligned operations?  I see that STREXD is out, 
and I can't think of anything else.  So bits 8, 16, 32 are up for grabs, which 
does fit a 64-byte page minimum.

That said...

> I'm guessing we'd need to have "this page has fine grained
> protection regions" imply "take the slow path" and then do
> the protection check in the slow path. Alex Graf pointed out
> to me a while back that we already have a data structure for
> handling sub-page-sized things in the slow path (the subpage
> handling in the memory system), but can we easily (or otherwise)
> use it, or would it be simpler just to have a separate thing?

I think it would be simpler to have a separate thing, since the regular subpage 
handling requires memory allocation.

I would just think about a bit, TLB_PROT_RECHECK or so, that not only takes the 
slow path through the helper, but also the slow path back through tlb_fill.

Since these are defined by system registers, I can imagine there can only be a 
few pages for which this fine grained handling might apply any any one time. 
This would certainly be preferable to reducing the effectiveness of the entire 
TLB by a factor of 16.


r~

  reply	other threads:[~2017-07-03 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-03 10:04 [Qemu-devel] handling emulation fine-grained memory protection Peter Maydell
2017-07-03 16:07 ` Richard Henderson [this message]
2017-07-03 16:40   ` Peter Maydell
2017-07-03 18:01     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24d9856c-dd4e-70d1-5eaf-3f36e70fad72@twiddle.net \
    --to=rth@twiddle.net \
    --cc=agraf@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).