From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58156) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c17Ct-000241-2o for qemu-devel@nongnu.org; Mon, 31 Oct 2016 03:40:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c17Cp-0000Sg-7C for qemu-devel@nongnu.org; Mon, 31 Oct 2016 03:40:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43308) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c17Co-0000Re-V7 for qemu-devel@nongnu.org; Mon, 31 Oct 2016 03:40:31 -0400 References: <1477448651-4474-1-git-send-email-jasowang@redhat.com> <1477448651-4474-10-git-send-email-jasowang@redhat.com> <20161030131323.7dc17bcd@bahia> <3baa4c61-f984-ec03-b8c2-0d2f367f3594@cn.fujitsu.com> From: Jason Wang Message-ID: <24dd6bd4-69fd-1a21-c8bd-207b1f4b1ee7@redhat.com> Date: Mon, 31 Oct 2016 15:40:25 +0800 MIME-Version: 1.0 In-Reply-To: <3baa4c61-f984-ec03-b8c2-0d2f367f3594@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 9/9] colo-proxy: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhang Chen , Greg Kurz Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, Stefan Hajnoczi On 2016=E5=B9=B410=E6=9C=8831=E6=97=A5 14:37, Zhang Chen wrote: > > > On 10/30/2016 08:13 PM, Greg Kurz wrote: >> On Wed, 26 Oct 2016 10:24:11 +0800 >> Jason Wang wrote: >> >>> From: Zhang Chen >>> >>> Fix memory leak in colo-compare.c and filter-rewriter.c >>> Report by Coverity and add some comments. >>> >>> Signed-off-by: Zhang Chen >>> Reviewed-by: zhanghailiang >>> Signed-off-by: Jason Wang >>> --- >> Hi, >> >> This commit breaks --enable-trace-backends=3Dust builds in travis (#17= ): >> >> In file included from ./trace/generated-tracers.h:5966:0, >> from /home/travis/build/gkurz/qemu/include/trace.h:4= , >> from qapi/qapi-visit-core.c:22: >> ./trace/generated-ust-provider.h:18625:3: error: unknown type name=20 >> =E2=80=98_TP_EXPROTOint=E2=80=99 >> In file included from /home/travis/build/gkurz/qemu/include/trace.h:4:= 0, >> from qapi/qapi-visit-core.c:22: >> ./trace/generated-tracers.h: In function =E2=80=98trace_colo_compare_p= kt_info=E2=80=99: >> ./trace/generated-tracers.h:19249:432: error: expected string literal=20 >> before =E2=80=98_SDT_ASM_OPERANDS_ssize=E2=80=99 >> ./trace/generated-tracers.h:19249:432: error: implicit declaration of=20 >> function =E2=80=98__tracepoint_cb_qemu___colo_compare_pkt_info=E2=80=99= =20 >> [-Werror=3Dimplicit-function-declaration] >> ./trace/generated-tracers.h:19249:432: error: nested extern=20 >> declaration of =E2=80=98__tracepoint_cb_qemu___colo_compare_pkt_info=E2= =80=99=20 >> [-Werror=3Dnested-externs] >> cc1: all warnings being treated as errors >> make: *** [qapi/qapi-visit-core.o] Error 1 >> make: *** Waiting for unfinished jobs.... >> >> https://travis-ci.org/gkurz/qemu/jobs/171641119 > > I got your point and test it, same problem in here. > I found that when trace args >10 it not work(this trace have 11 args), > else it works well like that: > > colo_compare_pkt_info(const char *src, const char *dst, uint32_t pseq,=20 > uint32_t pack, uint32_t sseq, uint32_t sack, int res, uint32_t pflag,=20 > uint32_t sflag, const char *src1) "src/dst: %s/%s p: seq/ack=3D%u/%u =20 > s: seq/ack=3D%u/%u res=3D%d flags=3D%x/%x %s\n" > > So I think this bug could be related to trace system, but I review=20 > trace codes nothing be found about this. > CC: stefan > > Thanks=20 We met similar issue in the past which looks like a limitation of the=20 backend. Btw, Alex Bennee has posted a workaround for this, could you please=20 review or ack on that patch? Thanks