From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csQwq-0000YV-HJ for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:28:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csQwn-00016i-8y for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:28:24 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:62974 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1csQwn-00016W-0j for qemu-devel@nongnu.org; Mon, 27 Mar 2017 05:28:21 -0400 From: Paul Durrant Date: Mon, 27 Mar 2017 09:28:18 +0000 Message-ID: <24e4427dea5d4991bf8e64227886cb86@AMSPEX02CL03.citrite.net> References: <20170327074245.3821-1-jgross@suse.com> <1330e0a0d9814073b39b52bd6e08a6a8@AMSPEX02CL03.citrite.net> <552de1bb-46bf-1579-d8b2-763d4612eb44@suse.com> In-Reply-To: <552de1bb-46bf-1579-d8b2-763d4612eb44@suse.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v2] configure: use pkg-config for obtaining xen version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Juergen Gross' , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" Cc: Anthony Perard , "kraxel@redhat.com" , "sstabellini@kernel.org" > -----Original Message----- > From: Juergen Gross [mailto:jgross@suse.com] > Sent: 27 March 2017 10:15 > To: Paul Durrant ; qemu-devel@nongnu.org; xen- > devel@lists.xenproject.org > Cc: Anthony Perard ; kraxel@redhat.com; > sstabellini@kernel.org > Subject: Re: [PATCH v2] configure: use pkg-config for obtaining xen versi= on >=20 > On 27/03/17 11:07, Paul Durrant wrote: > >> -----Original Message----- > >> From: Juergen Gross [mailto:jgross@suse.com] > >> Sent: 27 March 2017 08:43 > >> To: qemu-devel@nongnu.org; xen-devel@lists.xenproject.org > >> Cc: Anthony Perard ; kraxel@redhat.com; > >> sstabellini@kernel.org; Paul Durrant ; Juerge= n > >> Gross > >> Subject: [PATCH v2] configure: use pkg-config for obtaining xen versio= n > >> > >> Instead of trying to guess the Xen version to use by compiling various > >> test programs first just ask the system via pkg-config. Only if it > >> can't return the version fall back to the test program scheme. > >> > >> If configure is being called with dedicated flags for the Xen librarie= s > >> use those instead of the pkg-config output. This will avoid breaking > >> an in-tree Xen build of an old Xen version while a new Xen version is > >> installed on the build machine: pkg-config would pick up the installed > >> Xen config files as the Xen tree wouldn't contain any of them. > >> > >> Signed-off-by: Juergen Gross > >> --- > >> V2: - use pkg-config only if no Xen library paths have been specified = via > >> --extra-ldflags > >> - keep test program for detecting Xen 4.9 > > > > This all looks plausible but it doesn't seem to be working for me when > trying to build 4.8. I'm still getting a xen ctrl version of 40900... sti= ll trying to > figure out why. >=20 > I suppose you reverted my previous patch? >=20 Yes, I reverted that then applied this one. > Do you happen to have some stale 4.9 libraries in your Xen tree? > Yes, it was picking up a libxendevicemodel when it should not have been. It= would be handy if the probe compilations used --nostdlib, but that's not r= egression introduced by your patch. Now that pkg-config is used for out-of-= tree builds I guess it may be possible to add that though. =20 > What happens without this patch? >=20 > > Also, the whitespace changes later on in the patch should probably be s= plit > out. >=20 > Hmm, those are just due to the nesting level of the if's changed. > I don't think they can easily be split out without having a > malformed indentation. >=20 Ok, I see that now I look at the code rather than just the patch. So, havin= g fixed my linkage issue... Tested-by: Paul Durrant >=20 > Juergen