From: Richard Henderson <richard.henderson@linaro.org>
To: Laurent Vivier <laurent@vivier.eu>, qemu-devel@nongnu.org
Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Subject: Re: [PATCH] target/m68k: implement fmove.l #<data>,FPCR
Date: Mon, 1 Jun 2020 15:15:05 -0700 [thread overview]
Message-ID: <24e63485-dfce-96e7-7b68-90efeeec8fad@linaro.org> (raw)
In-Reply-To: <20200531110231.620711-1-laurent@vivier.eu>
On 5/31/20 4:02 AM, Laurent Vivier wrote:
> The immediate value mode was ignored and instruction execution
> ends to an invalid access mode.
>
> This was found running 'R' that set FPSR to 0 at startup with
> a 'fmove.l #0,FPSR' in qemu-system-m68k emulation and triggers a
> kernel crash:
>
> [ 56.640000] *** ADDRESS ERROR *** FORMAT=2
> [ 56.640000] Current process id is 728
> [ 56.640000] BAD KERNEL TRAP: 00000000
> [ 56.640000] Modules linked in: sg evdev mac_hid ip_tables x_tables sha1_generic hmac ipv6 nf_defrag_ipv6 autofs4 ext4 crc16 mbcache jbd2 crc32c_generic sd_mod t10_pi crc_t10dif crct10dif_generic crct10dif_common sr_mod cdrom mac_esp macsonic esp_scsi
> [ 56.640000] PC: [<00016a2c>] X_UNSUPP+0x2c/0x3c
> [ 56.640000] SR: 2004 SP: 3eb5e68c a2: c02e239a
> [ 56.640000] d0: 00000040 d1: 00000002 d2: 8002adec d3: 8002ad50
> [ 56.640000] d4: 8002c768 d5: 0000000d a0: ffffffc2 a1: ffffffc1
> [ 56.640000] Process R (pid: 728, task=a3dfda5d)
> [ 56.640000] Frame format=2 instr addr=00000000
> [ 56.650000] Stack from 3a4d9f30:
> [ 56.650000] 41000000 00000002 00000002 ffffffc2 ffffffc1 1fff0000 80000000 00000000
> [ 56.650000] 3fbf0000 80000000 00000000 00000000 20000000 00000000 7fff0000 ffffffff
> [ 56.650000] ffffffff 00000000 00050008 00000000 8000067c c02c2000 efffee20 000002d8
> [ 56.650000] 00002a28 3a4d9f98 00000002 00000014 fffffffe 8002c768 00000002 00000041
> [ 56.650000] 00000002 c041fc58 c0743758 ffffffff 00000000 0008c075 00002b24 00000012
> [ 56.650000] 000007d0 00000024 00000002 c05bef04 c05bef04 0000005e 00000077 c28aca70
> [ 56.650000] Call Trace: [<00050008>] copy_overflow+0x10/0x28
> [ 56.650000] [<00002a28>] buserr+0x20/0x28
> [ 56.650000] [<0008c075>] bpf_check+0x57f/0x1cfa
> [ 56.650000] [<00002b24>] syscall+0x8/0xc
> [ 56.650000] [<0000c019>] dn_sched_init+0x75/0x88
> [ 56.650000] Code: 1017 0200 00f0 0c00 0040 66ff 0000 05ac <f23c> 8800 0000 0000 f23c 9000 0000 0000 222e ff84 082e 0005 ff1c 6600 000a 0281
> [ 56.650000] Disabling lock debugging due to kernel taint
> ...
>
> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/translate.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-06-01 22:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 11:02 [PATCH] target/m68k: implement fmove.l #<data>,FPCR Laurent Vivier
2020-05-31 11:23 ` John Paul Adrian Glaubitz
2020-05-31 12:09 ` Laurent Vivier
2020-05-31 13:15 ` John Paul Adrian Glaubitz
2020-06-01 22:15 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e63485-dfce-96e7-7b68-90efeeec8fad@linaro.org \
--to=richard.henderson@linaro.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).