From: Thomas Huth <thuth@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org
Cc: David Carlier <devnexen@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only
Date: Mon, 6 Jul 2020 18:50:19 +0200 [thread overview]
Message-ID: <24f94e8a-450c-c620-7ca6-8684dc439438@redhat.com> (raw)
In-Reply-To: <15440bc7-a0f3-5cef-0d73-d9563a5e3650@redhat.com>
On 06/07/2020 16.00, Eric Blake wrote:
> On 7/3/20 10:12 AM, Thomas Huth wrote:
>
>>> +++ b/util/qemu-openpty.c
>>> @@ -35,7 +35,7 @@
>>> #include "qemu/osdep.h"
>>> #include "qemu-common.h"
>>> -#if defined(__GLIBC__)
>>> +#if defined CONFIG_PTY
>
>>
>> Shouldn't there be some parentheses around CONFIG_PTY here?
>
> No, they are optional, and omitting them is more consistent with the
> CONFIG_BSD just below.
Thanks, TIL - I'm doing so many years of C programming already, and
until now I never noticed any code that does not use parentheses after
"defined" ...
Thomas
next prev parent reply other threads:[~2020-07-06 17:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 14:56 [PATCH v3 0/9] Build fixes for Haiku Peter Maydell
2020-07-03 14:56 ` [PATCH v3 1/9] build: Enable BSD symbols " Peter Maydell
2020-07-03 14:56 ` [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only Peter Maydell
2020-07-03 15:12 ` Thomas Huth
2020-07-06 14:00 ` Eric Blake
2020-07-06 16:50 ` Thomas Huth [this message]
2020-07-03 14:56 ` [PATCH v3 3/9] build: Check that mlockall() exists Peter Maydell
2020-07-03 15:13 ` Thomas Huth
2020-07-03 14:56 ` [PATCH v3 4/9] osdep.h: Always include <sys/signal.h> if it exists Peter Maydell
2020-07-03 15:15 ` Thomas Huth
2020-07-03 15:21 ` Philippe Mathieu-Daudé
2020-07-03 14:56 ` [PATCH v3 5/9] osdep.h: For Haiku, define SIGIO as equivalent to SIGPOLL Peter Maydell
2020-07-03 15:16 ` Thomas Huth
2020-07-03 14:56 ` [PATCH v3 6/9] bswap.h: Include <endian.h> on Haiku for bswap operations Peter Maydell
2020-07-03 15:19 ` Thomas Huth
2020-07-03 15:22 ` Philippe Mathieu-Daudé
2020-07-03 14:56 ` [PATCH v3 7/9] util/compatfd.c: Only include <sys/syscall.h> if CONFIG_SIGNALFD Peter Maydell
2020-07-03 15:19 ` Thomas Huth
2020-07-03 15:29 ` Philippe Mathieu-Daudé
2020-07-03 14:56 ` [PATCH v3 8/9] util/oslib-posix.c: Implement qemu_init_exec_dir() for Haiku Peter Maydell
2020-07-03 14:56 ` [PATCH v3 9/9] util/drm: make portable by avoiding struct dirent d_type Peter Maydell
2020-07-11 18:44 ` [PATCH v3 0/9] Build fixes for Haiku Peter Maydell
2020-07-11 19:02 ` David CARLIER
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24f94e8a-450c-c620-7ca6-8684dc439438@redhat.com \
--to=thuth@redhat.com \
--cc=devnexen@gmail.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).