From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593E3C433E0 for ; Mon, 6 Jul 2020 17:09:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 222CD21582 for ; Mon, 6 Jul 2020 17:09:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="L6P17ssN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 222CD21582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40822 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jsUcK-0000ka-DA for qemu-devel@archiver.kernel.org; Mon, 06 Jul 2020 13:09:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jsUK7-0003qr-5n for qemu-devel@nongnu.org; Mon, 06 Jul 2020 12:50:31 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22333 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jsUK5-0004c0-Gg for qemu-devel@nongnu.org; Mon, 06 Jul 2020 12:50:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594054228; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=vyy7XlmZAqUOzJU+lzGMKvTs72VRKeP6UMX8EQynoh0=; b=L6P17ssNMeBkY4QfBj3swKvMRW2cJIbXeLVm24rMwtZY0xtax82dHRmd8Gcez9KREzA34S L3Gld5UlFv59Kum5JKN09U6OkxdVlyqGxWfnNXJ2tdp2r4JRFtjtw9z5GehApVm71qISi9 6A8TR+nELcx7Oq+4tzXc9Oxd2IjCnjM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-150-tdeFm6G6PkqACJaDfSoEnA-1; Mon, 06 Jul 2020 12:50:26 -0400 X-MC-Unique: tdeFm6G6PkqACJaDfSoEnA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CFED100CC86; Mon, 6 Jul 2020 16:50:25 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-144.ams2.redhat.com [10.36.112.144]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EDB1F1002380; Mon, 6 Jul 2020 16:50:21 +0000 (UTC) Subject: Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only To: Eric Blake , Peter Maydell , qemu-devel@nongnu.org References: <20200703145614.16684-1-peter.maydell@linaro.org> <20200703145614.16684-3-peter.maydell@linaro.org> <7b698fed-5203-2e8e-ddd3-6c1f06037393@redhat.com> <15440bc7-a0f3-5cef-0d73-d9563a5e3650@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <24f94e8a-450c-c620-7ca6-8684dc439438@redhat.com> Date: Mon, 6 Jul 2020 18:50:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <15440bc7-a0f3-5cef-0d73-d9563a5e3650@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.61; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/06 01:59:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Carlier , Gerd Hoffmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 06/07/2020 16.00, Eric Blake wrote: > On 7/3/20 10:12 AM, Thomas Huth wrote: > >>> +++ b/util/qemu-openpty.c >>> @@ -35,7 +35,7 @@ >>>   #include "qemu/osdep.h" >>>   #include "qemu-common.h" >>>   -#if defined(__GLIBC__) >>> +#if defined CONFIG_PTY > >> >> Shouldn't there be some parentheses around CONFIG_PTY here? > > No, they are optional, and omitting them is more consistent with the > CONFIG_BSD just below. Thanks, TIL - I'm doing so many years of C programming already, and until now I never noticed any code that does not use parentheses after "defined" ... Thomas