[PATCH trivial 00/21] spelling fixes for 8.2

[PATCH trivial 00/21] spelling fixes for 8.2

[Michael Tokarev]

For newly added lines after 8.1.

Michael Tokarev (21):
  bsd-user: spelling fixes: necesary, agrument, undocummented
  linux-user: spelling fixes: othe, necesary
  hw/cxl: spelling fixes: limitaions, potentialy, intialized
  gdbstub: spelling fix: respectivelly
  docs/about/deprecated.rst: spelling fix: becase
  docs/devel/migration.rst: spelling fix: doen't
  docs/system/arm/emulation.rst: spelling fix: Enhacements
  target/arm/tcg: spelling fixes: alse, addreses
  target/hppa: spelling fixes: Indicies, Truely
  migration/rdma.c: spelling fix: asume
  contrib/vhost-user-gpu/virgl.c: spelling fix: mesage
  hw/mem/memory-device.c: spelling fix: ontaining
  hw/net/cadence_gem.c: spelling fixes: Octects
  include/block/ufs.h: spelling fix: setted
  include/hw/hyperv/dynmem-proto.h: spelling fix: nunber
  include/hw/virtio/vhost.h: spelling fix: sate
  target/riscv/cpu.h: spelling fix: separatly
  tests/qtest/migration-test.c: spelling fix: bandwith
  tests/qtest/ufs-test.c: spelling fix: tranfer
  util/filemonitor-inotify.c: spelling fix: kenel
  util/range.c: spelling fix: inbetween

 bsd-user/bsd-mem.h               | 2 +-
 bsd-user/freebsd/os-proc.c       | 2 +-
 bsd-user/freebsd/os-stat.h       | 6 +++---
 contrib/vhost-user-gpu/virgl.c   | 2 +-
 docs/about/deprecated.rst        | 2 +-
 docs/devel/migration.rst         | 8 ++++----
 docs/system/arm/emulation.rst    | 2 +-
 gdbstub/gdbstub.c                | 2 +-
 hw/cxl/cxl-component-utils.c     | 4 ++--
 hw/cxl/cxl-mailbox-utils.c       | 2 +-
 hw/mem/memory-device.c           | 2 +-
 hw/net/cadence_gem.c             | 8 ++++----
 include/block/ufs.h              | 2 +-
 include/hw/cxl/cxl_device.h      | 2 +-
 include/hw/hyperv/dynmem-proto.h | 6 +++---
 include/hw/virtio/vhost.h        | 2 +-
 linux-user/ppc/vdso.S            | 2 +-
 linux-user/syscall.c             | 2 +-
 migration/rdma.c                 | 2 +-
 target/arm/tcg/helper-a64.c      | 2 +-
 target/arm/tcg/hflags.c          | 2 +-
 target/hppa/cpu.h                | 2 +-
 target/hppa/machine.c            | 2 +-
 target/riscv/cpu.h               | 4 ++--
 tests/qtest/migration-test.c     | 2 +-
 tests/qtest/ufs-test.c           | 2 +-
 util/filemonitor-inotify.c       | 2 +-
 util/range.c                     | 2 +-
 28 files changed, 40 insertions(+), 40 deletions(-)

-- 
2.39.2

[PATCH trivial 01/21] bsd-user: spelling fixes: necesary, agrument, undocummented

[Michael Tokarev]

Fixes: a99d74034754 "bsd-user: Implement do_obreak function"
Fixes: 8632729060bf "bsd-user: Implement freebsd_exec_common, used in implementing execve/fexecve."
Fixes: bf14f13d8be8 "bsd-user: Implement stat related syscalls"
Cc: Stacey Son <sson@FreeBSD.org>
Cc: Warner Losh <imp@bsdimp.com>
Cc: Kyle Evans <kevans@freebsd.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 bsd-user/bsd-mem.h         | 2 +-
 bsd-user/freebsd/os-proc.c | 2 +-
 bsd-user/freebsd/os-stat.h | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/bsd-user/bsd-mem.h b/bsd-user/bsd-mem.h
index c3e72e3b86..21d9bab889 100644
--- a/bsd-user/bsd-mem.h
+++ b/bsd-user/bsd-mem.h
@@ -235,7 +235,7 @@ static inline abi_long do_obreak(abi_ulong brk_val)
         return target_brk;
     }
 
-    /* Release heap if necesary */
+    /* Release heap if necessary */
     if (new_brk < old_brk) {
         target_munmap(new_brk, old_brk - new_brk);
 
diff --git a/bsd-user/freebsd/os-proc.c b/bsd-user/freebsd/os-proc.c
index 4e67ae4d56..e0203e259b 100644
--- a/bsd-user/freebsd/os-proc.c
+++ b/bsd-user/freebsd/os-proc.c
@@ -115,7 +115,7 @@ abi_long freebsd_exec_common(abi_ulong path_or_fd, abi_ulong guest_argp,
     }
 
     qarg0 = argp = g_new0(char *, argc + 9);
-    /* save the first agrument for the emulator */
+    /* save the first argument for the emulator */
     *argp++ = (char *)getprogname();
     qargp = argp;
     *argp++ = (char *)getprogname();
diff --git a/bsd-user/freebsd/os-stat.h b/bsd-user/freebsd/os-stat.h
index b20e270774..3bdc66aa98 100644
--- a/bsd-user/freebsd/os-stat.h
+++ b/bsd-user/freebsd/os-stat.h
@@ -146,7 +146,7 @@ static inline abi_long do_freebsd_fstatat(abi_long arg1, abi_long arg2,
     return ret;
 }
 
-/* undocummented nstat(char *path, struct nstat *ub) syscall */
+/* undocumented nstat(char *path, struct nstat *ub) syscall */
 static abi_long do_freebsd11_nstat(abi_long arg1, abi_long arg2)
 {
     abi_long ret;
@@ -162,7 +162,7 @@ static abi_long do_freebsd11_nstat(abi_long arg1, abi_long arg2)
     return ret;
 }
 
-/* undocummented nfstat(int fd, struct nstat *sb) syscall */
+/* undocumented nfstat(int fd, struct nstat *sb) syscall */
 static abi_long do_freebsd11_nfstat(abi_long arg1, abi_long arg2)
 {
     abi_long ret;
@@ -175,7 +175,7 @@ static abi_long do_freebsd11_nfstat(abi_long arg1, abi_long arg2)
     return ret;
 }
 
-/* undocummented nlstat(char *path, struct nstat *ub) syscall */
+/* undocumented nlstat(char *path, struct nstat *ub) syscall */
 static abi_long do_freebsd11_nlstat(abi_long arg1, abi_long arg2)
 {
     abi_long ret;
-- 
2.39.2

Re: [PATCH trivial 01/21] bsd-user: spelling fixes: necesary, agrument, undocummented

[Warner Losh]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

On Tue, Nov 14, 2023 at 9:58 AM Michael Tokarev <mjt@tls.msk.ru> wrote:

> Fixes: a99d74034754 "bsd-user: Implement do_obreak function"
> Fixes: 8632729060bf "bsd-user: Implement freebsd_exec_common, used in
> implementing execve/fexecve."
> Fixes: bf14f13d8be8 "bsd-user: Implement stat related syscalls"
> Cc: Stacey Son <sson@FreeBSD.org>
> Cc: Warner Losh <imp@bsdimp.com>
> Cc: Kyle Evans <kevans@freebsd.org>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  bsd-user/bsd-mem.h         | 2 +-
>  bsd-user/freebsd/os-proc.c | 2 +-
>  bsd-user/freebsd/os-stat.h | 6 +++---
>  3 files changed, 5 insertions(+), 5 deletions(-)


Reviewed-by: Warner Losh <imp@bsdimp.com>

These changes are fine, and won't have any hassles with merging to our
not-yet-merged branch.

[-- Attachment #2: Type: text/html, Size: 1424 bytes --]

[PATCH trivial 02/21] linux-user: spelling fixes: othe, necesary

[Michael Tokarev]

Fixes: e34136d93059 "linux-user/ppc: Add vdso"
Fixes: 86f04735ac20 "linux-user: Fix brk() to release pages"
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 linux-user/ppc/vdso.S | 2 +-
 linux-user/syscall.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/linux-user/ppc/vdso.S b/linux-user/ppc/vdso.S
index 689010db13..2e79ea9808 100644
--- a/linux-user/ppc/vdso.S
+++ b/linux-user/ppc/vdso.S
@@ -227,7 +227,7 @@ endf	__kernel_sigtramp_rt
 #ifndef _ARCH_PPC64
 	/*
 	 * The non-rt sigreturn has the same layout at a different offset.
-	 * Move the CFA and leave all othe other descriptions the same.
+	 * Move the CFA and leave all the other descriptions the same.
 	 */
 	.cfi_def_cfa	1, SIGNAL_FRAMESIZE + offsetof_sigframe_mcontext
 	nop
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 65ac3ac796..16ca5ea7b6 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -831,7 +831,7 @@ abi_long do_brk(abi_ulong brk_val)
         return target_brk;
     }
 
-    /* Release heap if necesary */
+    /* Release heap if necessary */
     if (new_brk < old_brk) {
         target_munmap(new_brk, old_brk - new_brk);
 
-- 
2.39.2

Re: [PATCH trivial 02/21] linux-user: spelling fixes: othe, necesary

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: e34136d93059 "linux-user/ppc: Add vdso"
> Fixes: 86f04735ac20 "linux-user: Fix brk() to release pages"
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Cc: Helge Deller <deller@gmx.de>
> Cc: Laurent Vivier <laurent@vivier.eu>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   linux-user/ppc/vdso.S | 2 +-
>   linux-user/syscall.c  | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 03/21] hw/cxl: spelling fixes: limitaions, potentialy, intialized

[Michael Tokarev]

Fixes: 388d6b574e28 "hw/cxl: Use switch statements for read and write of cachemem registers"
Fixes: 3314efd276ad "hw/cxl/mbox: Add Physical Switch Identify command."
Fixes: 004e3a93b814 "hw/cxl: Add tunneled command support to mailbox for switch cci."
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Fan Ni <fan.ni@samsung.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/cxl/cxl-component-utils.c | 4 ++--
 hw/cxl/cxl-mailbox-utils.c   | 2 +-
 include/hw/cxl/cxl_device.h  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/cxl/cxl-component-utils.c b/hw/cxl/cxl-component-utils.c
index d0245cc55d..29d477492b 100644
--- a/hw/cxl/cxl-component-utils.c
+++ b/hw/cxl/cxl-component-utils.c
@@ -81,7 +81,7 @@ static uint64_t cxl_cache_mem_read_reg(void *opaque, hwaddr offset,
         return 0;
     default:
         /*
-         * In line with specifiction limitaions on access sizes, this
+         * In line with specification limitaions on access sizes, this
          * routine is not called with other sizes.
          */
         g_assert_not_reached();
@@ -152,7 +152,7 @@ static void cxl_cache_mem_write_reg(void *opaque, hwaddr offset, uint64_t value,
         return;
     default:
         /*
-         * In line with specifiction limitaions on access sizes, this
+         * In line with specification limitaions on access sizes, this
          * routine is not called with other sizes.
          */
         g_assert_not_reached();
diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
index b365575097..6eff56fb1b 100644
--- a/hw/cxl/cxl-mailbox-utils.c
+++ b/hw/cxl/cxl-mailbox-utils.c
@@ -431,7 +431,7 @@ static CXLRetCode cmd_identify_switch_device(const struct cxl_cmd *cmd,
     out = (struct cxl_fmapi_ident_switch_dev_resp_pl *)payload_out;
     *out = (struct cxl_fmapi_ident_switch_dev_resp_pl) {
         .num_physical_ports = num_phys_ports + 1, /* 1 USP */
-        .num_vcss = 1, /* Not yet support multiple VCS - potentialy tricky */
+        .num_vcss = 1, /* Not yet support multiple VCS - potentially tricky */
         .active_vcs_bitmask[0] = 0x1,
         .total_vppbs = num_phys_ports + 1,
         .bound_vppbs = num_phys_ports + 1,
diff --git a/include/hw/cxl/cxl_device.h b/include/hw/cxl/cxl_device.h
index 61b7f897f7..befb5f884b 100644
--- a/include/hw/cxl/cxl_device.h
+++ b/include/hw/cxl/cxl_device.h
@@ -403,7 +403,7 @@ struct CXLType3Dev {
     CXLComponentState cxl_cstate;
     CXLDeviceState cxl_dstate;
     CXLCCI cci; /* Primary PCI mailbox CCI */
-    /* Always intialized as no way to know if a VDM might show up */
+    /* Always initialized as no way to know if a VDM might show up */
     CXLCCI vdm_fm_owned_ld_mctp_cci;
     CXLCCI ld0_cci;
 
-- 
2.39.2

Re: [PATCH trivial 03/21] hw/cxl: spelling fixes: limitaions, potentialy, intialized

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 388d6b574e28 "hw/cxl: Use switch statements for read and write of cachemem registers"
> Fixes: 3314efd276ad "hw/cxl/mbox: Add Physical Switch Identify command."
> Fixes: 004e3a93b814 "hw/cxl: Add tunneled command support to mailbox for switch cci."
> Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
> Cc: Fan Ni <fan.ni@samsung.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   hw/cxl/cxl-component-utils.c | 4 ++--
>   hw/cxl/cxl-mailbox-utils.c   | 2 +-
>   include/hw/cxl/cxl_device.h  | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 04/21] gdbstub: spelling fix: respectivelly

[Michael Tokarev]

Fixes: 761e3c10881b "gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT"
Cc: Matheus Branco Borella <dark.ryu.550@gmail.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 gdbstub/gdbstub.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index ebb912da1b..46d752bbc2 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -692,7 +692,7 @@ static int gdb_handle_vcont(const char *p)
     /*
      * target_count and last_target keep track of how many CPUs we are going to
      * step or resume, and a pointer to the state structure of one of them,
-     * respectivelly
+     * respectively
      */
     int target_count = 0;
     CPUState *last_target = NULL;
-- 
2.39.2

Re: [PATCH trivial 04/21] gdbstub: spelling fix: respectivelly

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 761e3c10881b "gdbstub: fixes cases where wrong threads were reported to GDB on SIGINT"
> Cc: Matheus Branco Borella <dark.ryu.550@gmail.com>
> Cc: "Alex Bennée" <alex.bennee@linaro.org
> Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   gdbstub/gdbstub.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
> index ebb912da1b..46d752bbc2 100644
> --- a/gdbstub/gdbstub.c
> +++ b/gdbstub/gdbstub.c
> @@ -692,7 +692,7 @@ static int gdb_handle_vcont(const char *p)
>       /*
>        * target_count and last_target keep track of how many CPUs we are going to
>        * step or resume, and a pointer to the state structure of one of them,
> -     * respectivelly
> +     * respectively
>        */
>       int target_count = 0;
>       CPUState *last_target = NULL;

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 05/21] docs/about/deprecated.rst: spelling fix: becase

[Michael Tokarev]

Fixes: 864128df465a "migration: Deprecate old compression method"
Cc: Juan Quintela <quintela@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 docs/about/deprecated.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
index 78550c07bf..6c84db90b5 100644
--- a/docs/about/deprecated.rst
+++ b/docs/about/deprecated.rst
@@ -514,5 +514,5 @@ old compression method (since 8.2)
 
 Compression method fails too much.  Too many races.  We are going to
 remove it if nobody fixes it.  For starters, migration-test
-compression tests are disabled becase they fail randomly.  If you need
+compression tests are disabled because they fail randomly.  If you need
 compression, use multifd compression methods.
-- 
2.39.2

Re: [PATCH trivial 05/21] docs/about/deprecated.rst: spelling fix: becase

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 864128df465a "migration: Deprecate old compression method"
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   docs/about/deprecated.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 78550c07bf..6c84db90b5 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -514,5 +514,5 @@ old compression method (since 8.2)
>   
>   Compression method fails too much.  Too many races.  We are going to
>   remove it if nobody fixes it.  For starters, migration-test
> -compression tests are disabled becase they fail randomly.  If you need
> +compression tests are disabled because they fail randomly.  If you need
>   compression, use multifd compression methods.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH trivial 05/21] docs/about/deprecated.rst: spelling fix: becase

[Juan Quintela]

Michael Tokarev <mjt@tls.msk.ru> wrote:
> Fixes: 864128df465a "migration: Deprecate old compression method"
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  docs/about/deprecated.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 78550c07bf..6c84db90b5 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -514,5 +514,5 @@ old compression method (since 8.2)
>  
>  Compression method fails too much.  Too many races.  We are going to
>  remove it if nobody fixes it.  For starters, migration-test
> -compression tests are disabled becase they fail randomly.  If you need
> +compression tests are disabled because they fail randomly.  If you need
>  compression, use multifd compression methods.

Reviewed-by: Juan Quintela <quintela@redhat.com>

queued.

[PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

[Michael Tokarev]

Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity"
Cc: Juan Quintela <quintela@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 docs/devel/migration.rst | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index 5adf4f12f7..51b1f61f5e 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -1061,7 +1061,7 @@ QEMU version, in this case pc-5.1.
 
 4 - qemu-5.1 -M pc-5.2  -> migrates to -> qemu-5.1 -M pc-5.2
 
-  This combination is not possible as the qemu-5.1 doen't understand
+  This combination is not possible as the qemu-5.1 does't understand
   pc-5.2 machine type.  So nothing to worry here.
 
 Now it comes the interesting ones, when both QEMU processes are
@@ -1214,7 +1214,7 @@ machine types to have the right value::
          ...
      };
 
-A device with diferent features on both sides
+A device with different features on both sides
 ---------------------------------------------
 
 Let's assume that we are using the same QEMU binary on both sides,
@@ -1294,12 +1294,12 @@ Host B:
 
 $ qemu-system-x86_64 -cpu host,taa-no=off
 
-And you would be able to migrate between them.  It is responsability
+And you would be able to migrate between them.  It is responsibility
 of the management application or of the user to make sure that the
 configuration is correct.  QEMU doesn't know how to look at this kind
 of features in general.
 
-Notice that we don't recomend to use -cpu host for migration.  It is
+Notice that we don't recommend to use -cpu host for migration.  It is
 used in this example because it makes the example simpler.
 
 Other devices have worse control about individual features.  If they
-- 
2.39.2

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity"
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   docs/devel/migration.rst | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
> index 5adf4f12f7..51b1f61f5e 100644
> --- a/docs/devel/migration.rst
> +++ b/docs/devel/migration.rst
> @@ -1061,7 +1061,7 @@ QEMU version, in this case pc-5.1.
>   
>   4 - qemu-5.1 -M pc-5.2  -> migrates to -> qemu-5.1 -M pc-5.2
>   
> -  This combination is not possible as the qemu-5.1 doen't understand
> +  This combination is not possible as the qemu-5.1 does't understand

You replaced one typo with another one :-)

  Thomas

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

[Michael Tokarev]

14.11.2023 22:05, Thomas Huth wrote:
> On 14/11/2023 17.58, Michael Tokarev wrote:
>> Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity"
>> Cc: Juan Quintela <quintela@redhat.com>
>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>> ---
>>   docs/devel/migration.rst | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
>> index 5adf4f12f7..51b1f61f5e 100644
>> --- a/docs/devel/migration.rst
>> +++ b/docs/devel/migration.rst
>> @@ -1061,7 +1061,7 @@ QEMU version, in this case pc-5.1.
>>   4 - qemu-5.1 -M pc-5.2  -> migrates to -> qemu-5.1 -M pc-5.2
>> -  This combination is not possible as the qemu-5.1 doen't understand
>> +  This combination is not possible as the qemu-5.1 does't understand
> 
> You replaced one typo with another one :-)

Heh. Lovely! :)

The "really-really-fixed" one (without resending):

-  This combination is not possible as the qemu-5.1 doen't understand
+  This combination is not possible as the qemu-5.1 doesn't understand
    pc-5.2 machine type.  So nothing to worry here.

;)

Thank you for the review and for spotting it!

/mjt

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

[Thomas Huth]

On 15/11/2023 07.41, Michael Tokarev wrote:
> 14.11.2023 22:05, Thomas Huth wrote:
>> On 14/11/2023 17.58, Michael Tokarev wrote:
>>> Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards 
>>> compatiblity"
>>> Cc: Juan Quintela <quintela@redhat.com>
>>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>>> ---
>>>   docs/devel/migration.rst | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
>>> index 5adf4f12f7..51b1f61f5e 100644
>>> --- a/docs/devel/migration.rst
>>> +++ b/docs/devel/migration.rst
>>> @@ -1061,7 +1061,7 @@ QEMU version, in this case pc-5.1.
>>>   4 - qemu-5.1 -M pc-5.2  -> migrates to -> qemu-5.1 -M pc-5.2
>>> -  This combination is not possible as the qemu-5.1 doen't understand
>>> +  This combination is not possible as the qemu-5.1 does't understand
>>
>> You replaced one typo with another one :-)
> 
> Heh. Lovely! :)
> 
> The "really-really-fixed" one (without resending):
> 
> -  This combination is not possible as the qemu-5.1 doen't understand
> +  This combination is not possible as the qemu-5.1 doesn't understand
>     pc-5.2 machine type.  So nothing to worry here.
> 
> ;)

With that fix:

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

[Michael Tokarev]

15.11.2023 09:46, Thomas Huth:
..
>> The "really-really-fixed" one (without resending):
>>
>> -  This combination is not possible as the qemu-5.1 doen't understand
>> +  This combination is not possible as the qemu-5.1 doesn't understand
>>     pc-5.2 machine type.  So nothing to worry here.
>>
>> ;)

Actually there's more in there than this 1 fix: the change has
other fixes too, and one of them is in heading, so "underline"
in the next line should be fixed too.

These spelling fixes are.. tough :)  Lemme see if I did multiple
changes like this somewhere else, pretending there's just one fix..

Actual commit (with your R-b tag still, as apparently you reviewed
all changes).
With updated Subject, new Fixes: tag, and a change in heading underlining):

From: Michael Tokarev <mjt@tls.msk.ru>
Date: Tue Nov 14 19:08:48 2023 +0300

     docs/devel/migration.rst: spelling fixes: doen't, diferent, responsability, recomend

     Fixes: 593c28c02c81 "migration/doc: How to migrate when hosts have different features"
     Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity"
     Reviewed-by: Thomas Huth <thuth@redhat.com>
     Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
index 5adf4f12f7..ec55089b25 100644
--- a/docs/devel/migration.rst
+++ b/docs/devel/migration.rst
@@ -1061,7 +1061,7 @@ QEMU version, in this case pc-5.1.

  4 - qemu-5.1 -M pc-5.2  -> migrates to -> qemu-5.1 -M pc-5.2

-  This combination is not possible as the qemu-5.1 doen't understand
+  This combination is not possible as the qemu-5.1 doesn't understand
    pc-5.2 machine type.  So nothing to worry here.

  Now it comes the interesting ones, when both QEMU processes are
@@ -1214,8 +1214,8 @@ machine types to have the right value::
           ...
       };

-A device with diferent features on both sides
----------------------------------------------
+A device with different features on both sides
+----------------------------------------------

  Let's assume that we are using the same QEMU binary on both sides,
  just to make the things easier.  But we have a device that has
@@ -1294,12 +1294,12 @@ Host B:

  $ qemu-system-x86_64 -cpu host,taa-no=off

-And you would be able to migrate between them.  It is responsability
+And you would be able to migrate between them.  It is responsibility
  of the management application or of the user to make sure that the
  configuration is correct.  QEMU doesn't know how to look at this kind
  of features in general.

-Notice that we don't recomend to use -cpu host for migration.  It is
+Notice that we don't recommend to use -cpu host for migration.  It is
  used in this example because it makes the example simpler.

  Other devices have worse control about individual features.  If they

Re: [PATCH trivial 06/21] docs/devel/migration.rst: spelling fix: doen't

[Juan Quintela]

Michael Tokarev <mjt@tls.msk.ru> wrote:
> 14.11.2023 22:05, Thomas Huth wrote:
>> On 14/11/2023 17.58, Michael Tokarev wrote:
>>> Fixes: 1aefe2ca1423 "migration/doc: Add documentation for backwards compatiblity"
>>> Cc: Juan Quintela <quintela@redhat.com>
>>> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
>>> ---
>>>   docs/devel/migration.rst | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/docs/devel/migration.rst b/docs/devel/migration.rst
>>> index 5adf4f12f7..51b1f61f5e 100644
>>> --- a/docs/devel/migration.rst
>>> +++ b/docs/devel/migration.rst
>>> @@ -1061,7 +1061,7 @@ QEMU version, in this case pc-5.1.
>>>   4 - qemu-5.1 -M pc-5.2  -> migrates to -> qemu-5.1 -M pc-5.2
>>> -  This combination is not possible as the qemu-5.1 doen't understand
>>> +  This combination is not possible as the qemu-5.1 does't understand
>> You replaced one typo with another one :-)
>
> Heh. Lovely! :)
>
> The "really-really-fixed" one (without resending):
>
> -  This combination is not possible as the qemu-5.1 doen't understand
> +  This combination is not possible as the qemu-5.1 doesn't understand
>    pc-5.2 machine type.  So nothing to worry here.
>
> ;)
>
> Thank you for the review and for spotting it!
>
> /mjt

Reviewed-by: Juan Quintela <quintela@redhat.com>
with the change.

[PATCH trivial 07/21] docs/system/arm/emulation.rst: spelling fix: Enhacements

[Michael Tokarev]

Fixes: c7c807f6dd6d "target/arm: Implement FEAT_Pauth2"
Cc: Aaron Lindsay <aaron@os.amperecomputing.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 docs/system/arm/emulation.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 47fd648035..0b604f9005 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -70,7 +70,7 @@ the following architecture extensions:
 - FEAT_PAN2 (AT S1E1R and AT S1E1W instruction variants affected by PSTATE.PAN)
 - FEAT_PAN3 (Support for SCTLR_ELx.EPAN)
 - FEAT_PAuth (Pointer authentication)
-- FEAT_PAuth2 (Enhacements to pointer authentication)
+- FEAT_PAuth2 (Enhancements to pointer authentication)
 - FEAT_PMULL (PMULL, PMULL2 instructions)
 - FEAT_PMUv3p1 (PMU Extensions v3.1)
 - FEAT_PMUv3p4 (PMU Extensions v3.4)
-- 
2.39.2

Re: [PATCH trivial 07/21] docs/system/arm/emulation.rst: spelling fix: Enhacements

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: c7c807f6dd6d "target/arm: Implement FEAT_Pauth2"
> Cc: Aaron Lindsay <aaron@os.amperecomputing.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   docs/system/arm/emulation.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
> index 47fd648035..0b604f9005 100644
> --- a/docs/system/arm/emulation.rst
> +++ b/docs/system/arm/emulation.rst
> @@ -70,7 +70,7 @@ the following architecture extensions:
>   - FEAT_PAN2 (AT S1E1R and AT S1E1W instruction variants affected by PSTATE.PAN)
>   - FEAT_PAN3 (Support for SCTLR_ELx.EPAN)
>   - FEAT_PAuth (Pointer authentication)
> -- FEAT_PAuth2 (Enhacements to pointer authentication)
> +- FEAT_PAuth2 (Enhancements to pointer authentication)
>   - FEAT_PMULL (PMULL, PMULL2 instructions)
>   - FEAT_PMUv3p1 (PMU Extensions v3.1)
>   - FEAT_PMUv3p4 (PMU Extensions v3.4)

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 08/21] target/arm/tcg: spelling fixes: alse, addreses

[Michael Tokarev]

Fixes: 179e9a3baccc "target/arm: Define new TB flag for ATA0"
Fixes: 5d7b37b5f675 "target/arm: Implement the CPY* instructions"
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 target/arm/tcg/helper-a64.c | 2 +-
 target/arm/tcg/hflags.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/arm/tcg/helper-a64.c b/target/arm/tcg/helper-a64.c
index ce4800b8d1..8ad84623d3 100644
--- a/target/arm/tcg/helper-a64.c
+++ b/target/arm/tcg/helper-a64.c
@@ -1414,7 +1414,7 @@ void HELPER(setge)(CPUARMState *env, uint32_t syndrome, uint32_t mtedesc)
 /*
  * Perform part of a memory copy from the guest memory at fromaddr
  * and extending for copysize bytes, to the guest memory at
- * toaddr. Both addreses are dirty.
+ * toaddr. Both addresses are dirty.
  *
  * Returns the number of bytes actually set, which might be less than
  * copysize; the caller should loop until the whole copy has been done.
diff --git a/target/arm/tcg/hflags.c b/target/arm/tcg/hflags.c
index 3d7fdce5c3..a6ebd7571a 100644
--- a/target/arm/tcg/hflags.c
+++ b/target/arm/tcg/hflags.c
@@ -327,7 +327,7 @@ static CPUARMTBFlags rebuild_hflags_a64(CPUARMState *env, int el, int fp_el,
             DP_TBFLAG_A64(flags, MTE0_ACTIVE, 1);
         }
         /*
-         * For unpriv tag-setting accesses we alse need ATA0. Again, in
+         * For unpriv tag-setting accesses we also need ATA0. Again, in
          * contexts where unpriv and normal insns are the same we
          * duplicate the ATA bit to save effort for translate-a64.c.
          */
-- 
2.39.2

Re: [PATCH trivial 08/21] target/arm/tcg: spelling fixes: alse, addreses

[Richard Henderson]

On 11/14/23 08:58, Michael Tokarev wrote:
> Fixes: 179e9a3baccc "target/arm: Define new TB flag for ATA0"
> Fixes: 5d7b37b5f675 "target/arm: Implement the CPY* instructions"
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   target/arm/tcg/helper-a64.c | 2 +-
>   target/arm/tcg/hflags.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

[PATCH trivial 09/21] target/hppa: spelling fixes: Indicies, Truely

[Michael Tokarev]

Fixes: bb67ec32a0bb "target/hppa: Include PSW_P in tb flags and mmu index"
Fixes: d7553f3591bb "target/hppa: Populate an interval tree with valid tlb entries"
Cc: Richard Henderson <richard.henderson@linaro.org>
---
 target/hppa/cpu.h     | 2 +-
 target/hppa/machine.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index cecec59700..80177c0df8 100644
--- a/target/hppa/cpu.h
+++ b/target/hppa/cpu.h
@@ -54,7 +54,7 @@
          1 << MMU_PL2_IDX    | 1 << MMU_PL2_P_IDX    |  \
          1 << MMU_USER_IDX   | 1 << MMU_USER_P_IDX)
 
-/* Indicies to flush for access_id changes. */
+/* Indices to flush for access_id changes. */
 #define HPPA_MMU_FLUSH_P_MASK \
         (1 << MMU_KERNEL_P_IDX | 1 << MMU_PL1_P_IDX  |  \
          1 << MMU_PL2_P_IDX    | 1 << MMU_USER_P_IDX)
diff --git a/target/hppa/machine.c b/target/hppa/machine.c
index 2f8e8cc5a1..15cbc5e6d0 100644
--- a/target/hppa/machine.c
+++ b/target/hppa/machine.c
@@ -129,7 +129,7 @@ static int tlb_post_load(void *opaque, int version_id)
 
     /*
      * Re-create the interval tree from the valid entries.
-     * Truely invalid entries should have start == end == 0.
+     * Truly invalid entries should have start == end == 0.
      * Otherwise it should be the in-flight tlb_partial entry.
      */
     for (uint32_t i = 0; i < ARRAY_SIZE(env->tlb); ++i) {
-- 
2.39.2

Re: [PATCH trivial 09/21] target/hppa: spelling fixes: Indicies, Truely

[Richard Henderson]

On 11/14/23 08:58, Michael Tokarev wrote:
> Fixes: bb67ec32a0bb "target/hppa: Include PSW_P in tb flags and mmu index"
> Fixes: d7553f3591bb "target/hppa: Populate an interval tree with valid tlb entries"
> Cc: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/hppa/cpu.h     | 2 +-
>   target/hppa/machine.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
> index cecec59700..80177c0df8 100644
> --- a/target/hppa/cpu.h
> +++ b/target/hppa/cpu.h
> @@ -54,7 +54,7 @@
>            1 << MMU_PL2_IDX    | 1 << MMU_PL2_P_IDX    |  \
>            1 << MMU_USER_IDX   | 1 << MMU_USER_P_IDX)
>   
> -/* Indicies to flush for access_id changes. */
> +/* Indices to flush for access_id changes. */
>   #define HPPA_MMU_FLUSH_P_MASK \
>           (1 << MMU_KERNEL_P_IDX | 1 << MMU_PL1_P_IDX  |  \
>            1 << MMU_PL2_P_IDX    | 1 << MMU_USER_P_IDX)
> diff --git a/target/hppa/machine.c b/target/hppa/machine.c
> index 2f8e8cc5a1..15cbc5e6d0 100644
> --- a/target/hppa/machine.c
> +++ b/target/hppa/machine.c
> @@ -129,7 +129,7 @@ static int tlb_post_load(void *opaque, int version_id)
>   
>       /*
>        * Re-create the interval tree from the valid entries.
> -     * Truely invalid entries should have start == end == 0.
> +     * Truly invalid entries should have start == end == 0.
>        * Otherwise it should be the in-flight tlb_partial entry.
>        */
>       for (uint32_t i = 0; i < ARRAY_SIZE(env->tlb); ++i) {

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

[PATCH trivial 10/21] migration/rdma.c: spelling fix: asume

[Michael Tokarev]

Fixes: 67c31c9c1af1 "migration: Don't abuse qemu_file transferred for RDMA"
Cc: Juan Quintela <quintela@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 migration/rdma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/rdma.c b/migration/rdma.c
index 6a29e53daf..04debab5d9 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2204,7 +2204,7 @@ retry:
     stat64_add(&mig_stats.normal_pages, sge.length / qemu_target_page_size());
     /*
      * We are adding to transferred the amount of data written, but no
-     * overhead at all.  I will asume that RDMA is magicaly and don't
+     * overhead at all.  I will assume that RDMA is magicaly and don't
      * need to transfer (at least) the addresses where it wants to
      * write the pages.  Here it looks like it should be something
      * like:
-- 
2.39.2

Re: [PATCH trivial 10/21] migration/rdma.c: spelling fix: asume

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 67c31c9c1af1 "migration: Don't abuse qemu_file transferred for RDMA"
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   migration/rdma.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/rdma.c b/migration/rdma.c
> index 6a29e53daf..04debab5d9 100644
> --- a/migration/rdma.c
> +++ b/migration/rdma.c
> @@ -2204,7 +2204,7 @@ retry:
>       stat64_add(&mig_stats.normal_pages, sge.length / qemu_target_page_size());
>       /*
>        * We are adding to transferred the amount of data written, but no
> -     * overhead at all.  I will asume that RDMA is magicaly and don't
> +     * overhead at all.  I will assume that RDMA is magicaly and don't
>        * need to transfer (at least) the addresses where it wants to
>        * write the pages.  Here it looks like it should be something
>        * like:

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 11/21] contrib/vhost-user-gpu/virgl.c: spelling fix: mesage

[Michael Tokarev]

Fixes: e3c82fe04f31 "contrib/vhost-user-gpu: add support for sending dmabuf modifiers"
Cc: Erico Nunes <ernunes@redhat.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 contrib/vhost-user-gpu/virgl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
index 1da6cc1588..d1ccdf7d06 100644
--- a/contrib/vhost-user-gpu/virgl.c
+++ b/contrib/vhost-user-gpu/virgl.c
@@ -401,7 +401,7 @@ virgl_cmd_set_scanout(VuGpu *g,
 
         if (g->use_modifiers) {
             /*
-             * The mesage uses all the fields set in dmabuf_scanout plus
+             * The message uses all the fields set in dmabuf_scanout plus
              * modifiers which is appended after VhostUserGpuDMABUFScanout.
              */
             msg.request = VHOST_USER_GPU_DMABUF_SCANOUT2;
-- 
2.39.2

Re: [PATCH trivial 11/21] contrib/vhost-user-gpu/virgl.c: spelling fix: mesage

[Marc-André Lureau]

On Tue, Nov 14, 2023 at 8:58 PM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> Fixes: e3c82fe04f31 "contrib/vhost-user-gpu: add support for sending dmabuf modifiers"
> Cc: Erico Nunes <ernunes@redhat.com>
> Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

> ---
>  contrib/vhost-user-gpu/virgl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/vhost-user-gpu/virgl.c b/contrib/vhost-user-gpu/virgl.c
> index 1da6cc1588..d1ccdf7d06 100644
> --- a/contrib/vhost-user-gpu/virgl.c
> +++ b/contrib/vhost-user-gpu/virgl.c
> @@ -401,7 +401,7 @@ virgl_cmd_set_scanout(VuGpu *g,
>
>          if (g->use_modifiers) {
>              /*
> -             * The mesage uses all the fields set in dmabuf_scanout plus
> +             * The message uses all the fields set in dmabuf_scanout plus
>               * modifiers which is appended after VhostUserGpuDMABUFScanout.
>               */
>              msg.request = VHOST_USER_GPU_DMABUF_SCANOUT2;
> --
> 2.39.2
>

[PATCH trivial 12/21] hw/mem/memory-device.c: spelling fix: ontaining

[Michael Tokarev]

Fixes: 6c1b28e9e405 "memory-device: Support empty memory devices"
Cc: David Hildenbrand <david@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/mem/memory-device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index e0704b8dc3..a1b1af26bc 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -29,7 +29,7 @@ static bool memory_device_is_empty(const MemoryDeviceState *md)
     /* dropping const here is fine as we don't touch the memory region */
     mr = mdc->get_memory_region((MemoryDeviceState *)md, &local_err);
     if (local_err) {
-        /* Not empty, we'll report errors later when ontaining the MR again. */
+        /* Not empty, we'll report errors later when containing the MR again. */
         error_free(local_err);
         return false;
     }
-- 
2.39.2

Re: [PATCH trivial 12/21] hw/mem/memory-device.c: spelling fix: ontaining

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 6c1b28e9e405 "memory-device: Support empty memory devices"
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   hw/mem/memory-device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
> index e0704b8dc3..a1b1af26bc 100644
> --- a/hw/mem/memory-device.c
> +++ b/hw/mem/memory-device.c
> @@ -29,7 +29,7 @@ static bool memory_device_is_empty(const MemoryDeviceState *md)
>       /* dropping const here is fine as we don't touch the memory region */
>       mr = mdc->get_memory_region((MemoryDeviceState *)md, &local_err);
>       if (local_err) {
> -        /* Not empty, we'll report errors later when ontaining the MR again. */
> +        /* Not empty, we'll report errors later when containing the MR again. */
>           error_free(local_err);
>           return false;
>       }

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 13/21] hw/net/cadence_gem.c: spelling fixes: Octects

[Michael Tokarev]

Fixes: c755c943aa2e "hw/net/cadence_gem: use REG32 macro for register definitions"
Cc: Luc Michel <luc.michel@amd.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/net/cadence_gem.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
index 5b989f5b52..19adbc0e19 100644
--- a/hw/net/cadence_gem.c
+++ b/hw/net/cadence_gem.c
@@ -225,8 +225,8 @@ REG32(WOLAN, 0xb8) /* Wake on LAN reg */
 REG32(IPGSTRETCH, 0xbc) /* IPG Stretch reg */
 REG32(SVLAN, 0xc0) /* Stacked VLAN reg */
 REG32(MODID, 0xfc) /* Module ID reg */
-REG32(OCTTXLO, 0x100) /* Octects transmitted Low reg */
-REG32(OCTTXHI, 0x104) /* Octects transmitted High reg */
+REG32(OCTTXLO, 0x100) /* Octets transmitted Low reg */
+REG32(OCTTXHI, 0x104) /* Octets transmitted High reg */
 REG32(TXCNT, 0x108) /* Error-free Frames transmitted */
 REG32(TXBCNT, 0x10c) /* Error-free Broadcast Frames */
 REG32(TXMCNT, 0x110) /* Error-free Multicast Frame */
@@ -245,8 +245,8 @@ REG32(EXCESSCOLLCNT, 0x140) /* Excessive Collision Frames */
 REG32(LATECOLLCNT, 0x144) /* Late Collision Frames */
 REG32(DEFERTXCNT, 0x148) /* Deferred Transmission Frames */
 REG32(CSENSECNT, 0x14c) /* Carrier Sense Error Counter */
-REG32(OCTRXLO, 0x150) /* Octects Received register Low */
-REG32(OCTRXHI, 0x154) /* Octects Received register High */
+REG32(OCTRXLO, 0x150) /* Octets Received register Low */
+REG32(OCTRXHI, 0x154) /* Octets Received register High */
 REG32(RXCNT, 0x158) /* Error-free Frames Received */
 REG32(RXBROADCNT, 0x15c) /* Error-free Broadcast Frames RX */
 REG32(RXMULTICNT, 0x160) /* Error-free Multicast Frames RX */
-- 
2.39.2

Re: [PATCH trivial 13/21] hw/net/cadence_gem.c: spelling fixes: Octects

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: c755c943aa2e "hw/net/cadence_gem: use REG32 macro for register definitions"
> Cc: Luc Michel <luc.michel@amd.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   hw/net/cadence_gem.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH trivial 13/21] hw/net/cadence_gem.c: spelling fixes: Octects

[Luc Michel]

On 19:58 Tue 14 Nov     , Michael Tokarev wrote:
> Fixes: c755c943aa2e "hw/net/cadence_gem: use REG32 macro for register definitions"
> Cc: Luc Michel <luc.michel@amd.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Reviewed-by: Luc Michel <luc.michel@amd.com>

> ---
>  hw/net/cadence_gem.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index 5b989f5b52..19adbc0e19 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -225,8 +225,8 @@ REG32(WOLAN, 0xb8) /* Wake on LAN reg */
>  REG32(IPGSTRETCH, 0xbc) /* IPG Stretch reg */
>  REG32(SVLAN, 0xc0) /* Stacked VLAN reg */
>  REG32(MODID, 0xfc) /* Module ID reg */
> -REG32(OCTTXLO, 0x100) /* Octects transmitted Low reg */
> -REG32(OCTTXHI, 0x104) /* Octects transmitted High reg */
> +REG32(OCTTXLO, 0x100) /* Octets transmitted Low reg */
> +REG32(OCTTXHI, 0x104) /* Octets transmitted High reg */
>  REG32(TXCNT, 0x108) /* Error-free Frames transmitted */
>  REG32(TXBCNT, 0x10c) /* Error-free Broadcast Frames */
>  REG32(TXMCNT, 0x110) /* Error-free Multicast Frame */
> @@ -245,8 +245,8 @@ REG32(EXCESSCOLLCNT, 0x140) /* Excessive Collision Frames */
>  REG32(LATECOLLCNT, 0x144) /* Late Collision Frames */
>  REG32(DEFERTXCNT, 0x148) /* Deferred Transmission Frames */
>  REG32(CSENSECNT, 0x14c) /* Carrier Sense Error Counter */
> -REG32(OCTRXLO, 0x150) /* Octects Received register Low */
> -REG32(OCTRXHI, 0x154) /* Octects Received register High */
> +REG32(OCTRXLO, 0x150) /* Octets Received register Low */
> +REG32(OCTRXHI, 0x154) /* Octets Received register High */
>  REG32(RXCNT, 0x158) /* Error-free Frames Received */
>  REG32(RXBROADCNT, 0x15c) /* Error-free Broadcast Frames RX */
>  REG32(RXMULTICNT, 0x160) /* Error-free Multicast Frames RX */
> --
> 2.39.2
> 

-- 

[PATCH trivial 14/21] include/block/ufs.h: spelling fix: setted

[Michael Tokarev]

Fixes: bc4e68d362ec "hw/ufs: Initial commit for emulated Universal-Flash-Storage"
Cc: Jeuk Kim <jeuk20.kim@samsung.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/block/ufs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/block/ufs.h b/include/block/ufs.h
index 0b6ec0814d..d61598b8f3 100644
--- a/include/block/ufs.h
+++ b/include/block/ufs.h
@@ -657,7 +657,7 @@ typedef struct QEMU_PACKED UtpTaskReqDesc {
 #define UFS_UPIU_MAX_WB_LUN_ID 8
 
 /*
- * WriteBooster buffer lifetime has a limit setted by vendor.
+ * WriteBooster buffer lifetime has a limit set by vendor.
  * If it is over the limit, WriteBooster feature will be disabled.
  */
 #define UFS_WB_EXCEED_LIFETIME 0x0B
-- 
2.39.2

Re: [PATCH trivial 14/21] include/block/ufs.h: spelling fix: setted

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: bc4e68d362ec "hw/ufs: Initial commit for emulated Universal-Flash-Storage"
> Cc: Jeuk Kim <jeuk20.kim@samsung.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   include/block/ufs.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/block/ufs.h b/include/block/ufs.h
> index 0b6ec0814d..d61598b8f3 100644
> --- a/include/block/ufs.h
> +++ b/include/block/ufs.h
> @@ -657,7 +657,7 @@ typedef struct QEMU_PACKED UtpTaskReqDesc {
>   #define UFS_UPIU_MAX_WB_LUN_ID 8
>   
>   /*
> - * WriteBooster buffer lifetime has a limit setted by vendor.
> + * WriteBooster buffer lifetime has a limit set by vendor.
>    * If it is over the limit, WriteBooster feature will be disabled.
>    */
>   #define UFS_WB_EXCEED_LIFETIME 0x0B

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 15/21] include/hw/hyperv/dynmem-proto.h: spelling fix: nunber

[Michael Tokarev]

Fixes: 4f80cd2f033e "Add Hyper-V Dynamic Memory Protocol definitions"
Cc: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/hw/hyperv/dynmem-proto.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/hw/hyperv/dynmem-proto.h b/include/hw/hyperv/dynmem-proto.h
index d0f9090ac4..a657786a94 100644
--- a/include/hw/hyperv/dynmem-proto.h
+++ b/include/hw/hyperv/dynmem-proto.h
@@ -232,7 +232,7 @@ struct dm_capabilities_resp_msg {
  * num_committed: Committed memory in pages.
  * page_file_size: The accumulated size of all page files
  *                 in the system in pages.
- * zero_free: The nunber of zero and free pages.
+ * zero_free: The number of zero and free pages.
  * page_file_writes: The writes to the page file in pages.
  * io_diff: An indicator of file cache efficiency or page file activity,
  *          calculated as File Cache Page Fault Count - Page Read Count.
@@ -275,7 +275,7 @@ struct dm_balloon {
  *
  * reservedz: Reserved; must be set to zero.
  * more_pages: If FALSE, this is the last message of the transaction.
- * if TRUE there will atleast one more message from the guest.
+ * if TRUE there will be at least one more message from the guest.
  *
  * range_count: The number of ranges in the range array.
  *
@@ -296,7 +296,7 @@ struct dm_balloon_response {
  * to the guest to give guest more memory.
  *
  * more_pages: If FALSE, this is the last message of the transaction.
- * if TRUE there will atleast one more message from the guest.
+ * if TRUE there will be at least one more message from the guest.
  *
  * reservedz: Reserved; must be set to zero.
  *
-- 
2.39.2

Re: [PATCH trivial 15/21] include/hw/hyperv/dynmem-proto.h: spelling fix: nunber

[Maciej S. Szmigiero]

On 14.11.2023 17:58, Michael Tokarev wrote:
> Fixes: 4f80cd2f033e "Add Hyper-V Dynamic Memory Protocol definitions"
> Cc: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---

Acked-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>

Thanks,
Maciej

[PATCH trivial 16/21] include/hw/virtio/vhost.h: spelling fix: sate

[Michael Tokarev]

Fixes: 4a00d5d7f4b6 "vhost: Add high-level state save/load functions"
Cc: Hanna Czenczek <hreitz@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 include/hw/virtio/vhost.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
index 05d7204a08..02477788df 100644
--- a/include/hw/virtio/vhost.h
+++ b/include/hw/virtio/vhost.h
@@ -456,7 +456,7 @@ int vhost_save_backend_state(struct vhost_dev *dev, QEMUFile *f, Error **errp);
  * Must only be called while the device and all its vrings are stopped
  * (`VHOST_TRANSFER_STATE_PHASE_STOPPED`).
  *
- * @dev: The vhost device to which to send the sate
+ * @dev: The vhost device to which to send the state
  * @f: Migration stream from which to load the state
  * @errp: Potential error message
  *
-- 
2.39.2

Re: [PATCH trivial 16/21] include/hw/virtio/vhost.h: spelling fix: sate

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 4a00d5d7f4b6 "vhost: Add high-level state save/load functions"
> Cc: Hanna Czenczek <hreitz@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   include/hw/virtio/vhost.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h
> index 05d7204a08..02477788df 100644
> --- a/include/hw/virtio/vhost.h
> +++ b/include/hw/virtio/vhost.h
> @@ -456,7 +456,7 @@ int vhost_save_backend_state(struct vhost_dev *dev, QEMUFile *f, Error **errp);
>    * Must only be called while the device and all its vrings are stopped
>    * (`VHOST_TRANSFER_STATE_PHASE_STOPPED`).
>    *
> - * @dev: The vhost device to which to send the sate
> + * @dev: The vhost device to which to send the state
>    * @f: Migration stream from which to load the state
>    * @errp: Potential error message
>    *

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 17/21] target/riscv/cpu.h: spelling fix: separatly

[Michael Tokarev]

Fixes: 40336d5b1d4c "target/riscv: Add HS-mode virtual interrupt and IRQ filtering support."
Cc: Rajnesh Kanwal <rkanwal@rivosinc.com>
Cc: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 target/riscv/cpu.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index bf58b0f0b5..d74b361be6 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -214,13 +214,13 @@ struct CPUArchState {
 
     /*
      * When mideleg[i]=0 and mvien[i]=1, sie[i] is no more
-     * alias of mie[i] and needs to be maintained separatly.
+     * alias of mie[i] and needs to be maintained separately.
      */
     uint64_t sie;
 
     /*
      * When hideleg[i]=0 and hvien[i]=1, vsie[i] is no more
-     * alias of sie[i] (mie[i]) and needs to be maintained separatly.
+     * alias of sie[i] (mie[i]) and needs to be maintained separately.
      */
     uint64_t vsie;
 
-- 
2.39.2

Re: [PATCH trivial 17/21] target/riscv/cpu.h: spelling fix: separatly

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 40336d5b1d4c "target/riscv: Add HS-mode virtual interrupt and IRQ filtering support."
> Cc: Rajnesh Kanwal <rkanwal@rivosinc.com>
> Cc: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   target/riscv/cpu.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index bf58b0f0b5..d74b361be6 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -214,13 +214,13 @@ struct CPUArchState {
>   
>       /*
>        * When mideleg[i]=0 and mvien[i]=1, sie[i] is no more
> -     * alias of mie[i] and needs to be maintained separatly.
> +     * alias of mie[i] and needs to be maintained separately.
>        */
>       uint64_t sie;
>   
>       /*
>        * When hideleg[i]=0 and hvien[i]=1, vsie[i] is no more
> -     * alias of sie[i] (mie[i]) and needs to be maintained separatly.
> +     * alias of sie[i] (mie[i]) and needs to be maintained separately.
>        */
>       uint64_t vsie;
>   

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH trivial 17/21] target/riscv/cpu.h: spelling fix: separatly

[Alistair Francis]

On Wed, Nov 15, 2023 at 3:04 AM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> Fixes: 40336d5b1d4c "target/riscv: Add HS-mode virtual interrupt and IRQ filtering support."
> Cc: Rajnesh Kanwal <rkanwal@rivosinc.com>
> Cc: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Reviewed-by: Alistair Francis <alistair.francis@wdc.com>

Alistair

> ---
>  target/riscv/cpu.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
> index bf58b0f0b5..d74b361be6 100644
> --- a/target/riscv/cpu.h
> +++ b/target/riscv/cpu.h
> @@ -214,13 +214,13 @@ struct CPUArchState {
>
>      /*
>       * When mideleg[i]=0 and mvien[i]=1, sie[i] is no more
> -     * alias of mie[i] and needs to be maintained separatly.
> +     * alias of mie[i] and needs to be maintained separately.
>       */
>      uint64_t sie;
>
>      /*
>       * When hideleg[i]=0 and hvien[i]=1, vsie[i] is no more
> -     * alias of sie[i] (mie[i]) and needs to be maintained separatly.
> +     * alias of sie[i] (mie[i]) and needs to be maintained separately.
>       */
>      uint64_t vsie;
>
> --
> 2.39.2
>
>

[PATCH trivial 18/21] tests/qtest/migration-test.c: spelling fix: bandwith

[Michael Tokarev]

Fixes: 17257b90be4f "tests: Add migration dirty-limit capability test"
Cc: Hyman Huang <yong.huang@smartx.com>
Cc: Juan Quintela <quintela@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 tests/qtest/migration-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 5752412b64..0fbaa6a90f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -3138,7 +3138,7 @@ static void test_migrate_dirty_limit(void)
     uint64_t throttle_us_per_full;
     /*
      * We want the test to be stable and as fast as possible.
-     * E.g., with 1Gb/s bandwith migration may pass without dirty limit,
+     * E.g., with 1Gb/s bandwidth migration may pass without dirty limit,
      * so we need to decrease a bandwidth.
      */
     const int64_t dirtylimit_period = 1000, dirtylimit_value = 50;
-- 
2.39.2

Re: [PATCH trivial 18/21] tests/qtest/migration-test.c: spelling fix: bandwith

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 17257b90be4f "tests: Add migration dirty-limit capability test"
> Cc: Hyman Huang <yong.huang@smartx.com>
> Cc: Juan Quintela <quintela@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   tests/qtest/migration-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 5752412b64..0fbaa6a90f 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -3138,7 +3138,7 @@ static void test_migrate_dirty_limit(void)
>       uint64_t throttle_us_per_full;
>       /*
>        * We want the test to be stable and as fast as possible.
> -     * E.g., with 1Gb/s bandwith migration may pass without dirty limit,
> +     * E.g., with 1Gb/s bandwidth migration may pass without dirty limit,
>        * so we need to decrease a bandwidth.
>        */
>       const int64_t dirtylimit_period = 1000, dirtylimit_value = 50;

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 19/21] tests/qtest/ufs-test.c: spelling fix: tranfer

[Michael Tokarev]

Fixes: 631c872614ac "tests/qtest: Introduce tests for UFS"
Cc: Jeuk Kim <jeuk20.kim@samsung.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 tests/qtest/ufs-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
index 5daf8c9c49..95e82f9472 100644
--- a/tests/qtest/ufs-test.c
+++ b/tests/qtest/ufs-test.c
@@ -319,7 +319,7 @@ static void ufs_init(QUfs *ufs, QGuestAllocator *alloc)
     ufs_wreg(ufs, A_IE, ie);
     ufs_wreg(ufs, A_UTRIACR, 0);
 
-    /* Enable tranfer request and task management request */
+    /* Enable transfer request and task management request */
     cap = ufs_rreg(ufs, A_CAP);
     nutrs = FIELD_EX32(cap, CAP, NUTRS) + 1;
     nutmrs = FIELD_EX32(cap, CAP, NUTMRS) + 1;
-- 
2.39.2

Re: [PATCH trivial 19/21] tests/qtest/ufs-test.c: spelling fix: tranfer

[Thomas Huth]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 631c872614ac "tests/qtest: Introduce tests for UFS"
> Cc: Jeuk Kim <jeuk20.kim@samsung.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   tests/qtest/ufs-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
> index 5daf8c9c49..95e82f9472 100644
> --- a/tests/qtest/ufs-test.c
> +++ b/tests/qtest/ufs-test.c
> @@ -319,7 +319,7 @@ static void ufs_init(QUfs *ufs, QGuestAllocator *alloc)
>       ufs_wreg(ufs, A_IE, ie);
>       ufs_wreg(ufs, A_UTRIACR, 0);
>   
> -    /* Enable tranfer request and task management request */
> +    /* Enable transfer request and task management request */
>       cap = ufs_rreg(ufs, A_CAP);
>       nutrs = FIELD_EX32(cap, CAP, NUTRS) + 1;
>       nutmrs = FIELD_EX32(cap, CAP, NUTMRS) + 1;

Reviewed-by: Thomas Huth <thuth@redhat.com>

[PATCH trivial 20/21] util/filemonitor-inotify.c: spelling fix: kenel

[Michael Tokarev]

Fixes: 2e12dd405c66 "util/filemonitor-inotify: qemu_file_monitor_watch(): assert no overflow"
Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 util/filemonitor-inotify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/filemonitor-inotify.c b/util/filemonitor-inotify.c
index 2121111f38..7352b9fe53 100644
--- a/util/filemonitor-inotify.c
+++ b/util/filemonitor-inotify.c
@@ -89,7 +89,7 @@ static void qemu_file_monitor_watch(void *arg)
         struct inotify_event *ev = (struct inotify_event *)(buf + used);
 
         /*
-         * We trust the kenel to provide valid buffer with complete event
+         * We trust the kernel to provide valid buffer with complete event
          * records.
          */
         assert(len - used >= sizeof(struct inotify_event));
-- 
2.39.2

Re: [PATCH trivial 20/21] util/filemonitor-inotify.c: spelling fix: kenel

[Vladimir Sementsov-Ogievskiy]

On 14.11.23 19:58, Michael Tokarev wrote:
> Fixes: 2e12dd405c66 "util/filemonitor-inotify: qemu_file_monitor_watch(): assert no overflow"
> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>


-- 
Best regards,
Vladimir

[PATCH trivial 21/21] util/range.c: spelling fix: inbetween

[Michael Tokarev]

Fixes: b439595a08d7 "range: Introduce range_inverse_array()"
Cc: Eric Auger <eric.auger@redhat.com>
Cc: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 util/range.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/range.c b/util/range.c
index 9605ccfcbe..f3f40098d5 100644
--- a/util/range.c
+++ b/util/range.c
@@ -98,7 +98,7 @@ void range_inverse_array(GList *in, GList **rev,
         out = append_new_range(out, low, MIN(range_lob(r) - 1, high));
     }
 
-    /* insert a range inbetween each original range until we reach high */
+    /* insert a range in between each original range until we reach high */
     for (; l->next; l = l->next) {
         r = (Range *)l->data;
         rn = (Range *)l->next->data;
-- 
2.39.2

Re: [PATCH trivial 21/21] util/range.c: spelling fix: inbetween

[Eric Auger]

On 11/14/23 17:58, Michael Tokarev wrote:
> Fixes: b439595a08d7 "range: Introduce range_inverse_array()"
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Eric

> ---
>  util/range.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/range.c b/util/range.c
> index 9605ccfcbe..f3f40098d5 100644
> --- a/util/range.c
> +++ b/util/range.c
> @@ -98,7 +98,7 @@ void range_inverse_array(GList *in, GList **rev,
>          out = append_new_range(out, low, MIN(range_lob(r) - 1, high));
>      }
>  
> -    /* insert a range inbetween each original range until we reach high */
> +    /* insert a range in between each original range until we reach high */
>      for (; l->next; l = l->next) {
>          r = (Range *)l->data;
>          rn = (Range *)l->next->data;

Re: [PATCH trivial 21/21] util/range.c: spelling fix: inbetween

[Cédric Le Goater]

On 11/14/23 17:58, Michael Tokarev wrote:
> Fixes: b439595a08d7 "range: Introduce range_inverse_array()"
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   util/range.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/util/range.c b/util/range.c
> index 9605ccfcbe..f3f40098d5 100644
> --- a/util/range.c
> +++ b/util/range.c
> @@ -98,7 +98,7 @@ void range_inverse_array(GList *in, GList **rev,
>           out = append_new_range(out, low, MIN(range_lob(r) - 1, high));
>       }
>   
> -    /* insert a range inbetween each original range until we reach high */
> +    /* insert a range in between each original range until we reach high */
>       for (; l->next; l = l->next) {
>           r = (Range *)l->data;
>           rn = (Range *)l->next->data;

Re: [PATCH trivial 14/21] include/block/ufs.h: spelling fix: setted

[Jeuk Kim]

On 14/11/2023 17.58, Michael Tokarev wrote:

> Fixes: bc4e68d362ec "hw/ufs: Initial commit for emulated Universal-Flash-Storage"
> Cc: Jeuk Kim <jeuk20.kim@samsung.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  include/block/ufs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/block/ufs.h b/include/block/ufs.h
> index 0b6ec0814d..d61598b8f3 100644
> --- a/include/block/ufs.h
> +++ b/include/block/ufs.h
> @@ -657,7 +657,7 @@ typedef struct QEMU_PACKED UtpTaskReqDesc {
>  #define UFS_UPIU_MAX_WB_LUN_ID 8
>  
>  /*
> - * WriteBooster buffer lifetime has a limit setted by vendor.
> + * WriteBooster buffer lifetime has a limit set by vendor.
>   * If it is over the limit, WriteBooster feature will be disabled.
>   */
>  #define UFS_WB_EXCEED_LIFETIME 0x0B
> -- 
> 2.39.2

Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>

Thanks,
Jeuk

Re: [PATCH trivial 19/21] tests/qtest/ufs-test.c: spelling fix: tranfer

[Jeuk Kim]

On 14/11/2023 17.58, Michael Tokarev wrote:
> Fixes: 631c872614ac "tests/qtest: Introduce tests for UFS"
> Cc: Jeuk Kim <jeuk20.kim@samsung.com>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   tests/qtest/ufs-test.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/ufs-test.c b/tests/qtest/ufs-test.c
> index 5daf8c9c49..95e82f9472 100644
> --- a/tests/qtest/ufs-test.c
> +++ b/tests/qtest/ufs-test.c
> @@ -319,7 +319,7 @@ static void ufs_init(QUfs *ufs, QGuestAllocator *alloc)
>       ufs_wreg(ufs, A_IE, ie);
>       ufs_wreg(ufs, A_UTRIACR, 0);
>   
> -    /* Enable tranfer request and task management request */
> +    /* Enable transfer request and task management request */
>       cap = ufs_rreg(ufs, A_CAP);
>       nutrs = FIELD_EX32(cap, CAP, NUTRS) + 1;
>       nutmrs = FIELD_EX32(cap, CAP, NUTMRS) + 1;

Reviewed-by: Jeuk Kim <jeuk20.kim@samsung.com>

Thanks,
Jeuk