Re: [PATCH v2 06/23] tests/functional: Convert avocado tests that just need a small adjustment

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 24/7/24 19:52, Thomas Huth wrote:
> These simple tests can be converted to stand-alone tests quite easily,
> e.g. by just setting the machine to 'none' now manually or by adding
> "-cpu" command line parameters, since we don't support the corresponding
> avocado tags in the new python test framework.
> 
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   tests/functional/meson.build                  |  6 ++
>   .../test_info_usernet.py}                     | 11 ++-
>   .../test_ppc_74xx.py}                         | 74 ++++++++-----------
>   .../version.py => functional/test_version.py} | 13 ++--
>   4 files changed, 53 insertions(+), 51 deletions(-)
>   rename tests/{avocado/info_usernet.py => functional/test_info_usernet.py} (87%)
>   mode change 100644 => 100755
>   rename tests/{avocado/ppc_74xx.py => functional/test_ppc_74xx.py} (74%)
>   mode change 100644 => 100755
>   rename tests/{avocado/version.py => functional/test_version.py} (78%)
>   mode change 100644 => 100755


> diff --git a/tests/avocado/version.py b/tests/functional/test_version.py
> old mode 100644
> new mode 100755
> similarity index 78%
> rename from tests/avocado/version.py
> rename to tests/functional/test_version.py
> index c6139568a1..5e566d76b1
> --- a/tests/avocado/version.py
> +++ b/tests/functional/test_version.py
> @@ -1,3 +1,5 @@
> +#!/usr/bin/env python3
> +#
>   # Version check example test
>   #
>   # Copyright (c) 2018 Red Hat, Inc.
> @@ -9,17 +11,18 @@
>   # later.  See the COPYING file in the top-level directory.
>   
>   
> -from avocado_qemu import QemuSystemTest
> +from qemu_test import QemuSystemTest
>   
>   
>   class Version(QemuSystemTest):
> -    """
> -    :avocado: tags=quick
> -    :avocado: tags=machine:none
> -    """
> +
>       def test_qmp_human_info_version(self):
> +        self.machine = 'none'

API is self.set_machine('none'), otherwise:

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>