From: David Hildenbrand <david@redhat.com>
To: David Miller <dmiller423@gmail.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: thuth@redhat.com, cohuck@redhat.com,
richard.henderson@linaro.org, farman@linux.ibm.com,
pasic@linux.ibm.com, borntraeger@linux.ibm.com
Subject: Re: [PATCH v3 3/3] s390x/tcg/tests: Tests for Miscellaneous-Instruction-Extensions Facility 3
Date: Wed, 16 Feb 2022 10:57:10 +0100 [thread overview]
Message-ID: <24fd99ab-d2b2-1c0c-7273-0321300cc5cc@redhat.com> (raw)
In-Reply-To: <b69367a6-7744-6dbf-c370-3019bd66965c@gmail.com>
On 15.02.22 21:27, David Miller wrote:
> tests/tcg/s390x/mie3-compl.c: [N]*K instructions
> tests/tcg/s390x/mie3-mvcrl.c: MVCRL instruction
> tests/tcg/s390x/mie3-sel.c: SELECT instruction
>
> Signed-off-by: David Miller <dmiller423@gmail.com>
> ---
> tests/tcg/s390x/Makefile.target | 2 +-
> tests/tcg/s390x/mie3-compl.c | 56 +++++++++++++++++++++++++++++++++
> tests/tcg/s390x/mie3-mvcrl.c | 31 ++++++++++++++++++
> tests/tcg/s390x/mie3-sel.c | 42 +++++++++++++++++++++++++
> 4 files changed, 130 insertions(+), 1 deletion(-)
> create mode 100644 tests/tcg/s390x/mie3-compl.c
> create mode 100644 tests/tcg/s390x/mie3-mvcrl.c
> create mode 100644 tests/tcg/s390x/mie3-sel.c
>
> diff --git a/tests/tcg/s390x/Makefile.target
> b/tests/tcg/s390x/Makefile.target
> index 1a7238b4eb..16b9d45307 100644
> --- a/tests/tcg/s390x/Makefile.target
> +++ b/tests/tcg/s390x/Makefile.target
> @@ -1,6 +1,6 @@
> S390X_SRC=$(SRC_PATH)/tests/tcg/s390x
> VPATH+=$(S390X_SRC)
> -CFLAGS+=-march=zEC12 -m64
> +CFLAGS+=-march=z15 -m64
> TESTS+=hello-s390x
> TESTS+=csst
> TESTS+=ipm
Your patch is missing the following hunk:
diff --git a/tests/tcg/s390x/Makefile.target b/tests/tcg/s390x/Makefile.target
index 16b9d45307..54e67446aa 100644
--- a/tests/tcg/s390x/Makefile.target
+++ b/tests/tcg/s390x/Makefile.target
@@ -7,6 +7,9 @@ TESTS+=ipm
TESTS+=exrl-trt
TESTS+=exrl-trtr
TESTS+=pack
+TESTS+=mie3-compl
+TESTS+=mie3-mvcrl
+TESTS+=mie3-sel
TESTS+=mvo
TESTS+=mvc
TESTS+=shift
With debian11, I can build the tests. However, mie3-sel seems to have an issue:
TEST mie3-compl on s390x
TEST mie3-mvcrl on s390x
TEST mie3-sel on s390x
timeout: the monitored command dumped core
make[3]: *** [../Makefile.target:156: run-mie3-sel] Error 132
make[2]: *** [/home/dhildenb/git/qemu/tests/tcg/Makefile.qemu:102: run-guest-tests] Error 2
make[1]: *** [/home/dhildenb/git/qemu/tests/Makefile.include:59: run-tcg-tests-s390x-linux-user] Error 2
make[1]: Leaving directory '/home/dhildenb/git/qemu/build'
make: *** [GNUmakefile:11: run-tcg-tests-s390x-linux-user] Error 2
qemu-s390x gets killed via
"Program terminated with signal SIGILL, Illegal instruction."
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2022-02-16 10:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 20:27 [PATCH v3 3/3] s390x/tcg/tests: Tests for Miscellaneous-Instruction-Extensions Facility 3 David Miller
2022-02-16 9:17 ` David Hildenbrand
2022-02-16 9:28 ` Christian Borntraeger
2022-02-16 9:30 ` David Hildenbrand
2022-02-16 9:43 ` Thomas Huth
2022-02-16 9:53 ` David Hildenbrand
2022-02-16 14:19 ` Alex Bennée
2022-02-16 14:27 ` David Hildenbrand
2022-02-16 9:57 ` David Hildenbrand [this message]
2022-02-16 10:58 ` David Hildenbrand
2022-02-16 11:05 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24fd99ab-d2b2-1c0c-7273-0321300cc5cc@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=cohuck@redhat.com \
--cc=dmiller423@gmail.com \
--cc=farman@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).