From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7256C433E0 for ; Thu, 21 Jan 2021 05:57:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA4F22389B for ; Thu, 21 Jan 2021 05:57:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA4F22389B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47652 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2Sxx-00063p-PQ for qemu-devel@archiver.kernel.org; Thu, 21 Jan 2021 00:57:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2SwB-00050S-Dx for qemu-devel@nongnu.org; Thu, 21 Jan 2021 00:55:19 -0500 Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e]:45056) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2Sw9-0005iS-Rf for qemu-devel@nongnu.org; Thu, 21 Jan 2021 00:55:19 -0500 Received: by mail-pf1-x42e.google.com with SMTP id j12so845048pfj.12 for ; Wed, 20 Jan 2021 21:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=wA4gj7z6VSOz/xDWSM0YxUprikYGiqGFaEFK2iE8JxU=; b=aUxDDoSQ5RjDesgOOHL/PiQVBzRgu7suSB1G+i5Cx4NHNfzmlhTBlgRPfJQObiPeZY 6QY8tKkpH/AlT0ojaIPMkpy0WcIbD7mhrYJQ3yjpzw5rPQ9TPTFD3SYGEV0uGuP0SnJp vlI3viqzwnWe+osx30lcfho6sEXbgrggXua5p9WpVW8PZZhMtMkKuQMKZne7hKmL7xV/ LQCKyjdSmL8mc3DFRuGQd+UuvA+n9a/7BgMKFS8YPmXzZ542Kji73M/APhnthT5ToilF Pho+7iaRZI4WmPDsv61SHDusB+w4M7w4ODUMdZjVI5F+VD6FP36GC/qR7Z3WaLmEl2FI bJ/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=wA4gj7z6VSOz/xDWSM0YxUprikYGiqGFaEFK2iE8JxU=; b=ZK2N3OFPm13UKMpGpngwjdTzZz8XwfNeRhdZGQmi+mI7t/bC2FGyyawcg6ss+PtxoC tdTVxpJ2aCQEE/OybZ4QRdwax+yslPrsV4XT7/OiuNfQz8C47CKMI07sn0s67HAxYhtf mMIC5jiaLBPyxEAMaYCK2oL8kdK8PZfXL2120o8qpb//UwJSZohEHIfxQ1sbJnpMlbQ0 cxi7gSkxwleL7ukkdDZX+l+2l86x3qhC4Td8QUMlbQiyNBBbxbQrDBf3hWzOBRMN0E8+ AEw3fP7EoMuTbgRV6WmUGH2QJDRX+VrGdtKUteBEFqfVja276S7phbeJ1GCxa6aheV06 ycGw== X-Gm-Message-State: AOAM530ksNtV3EBOwTmYYuA527mmXI2CjHdOQ5wxj4xb7xA1+K7Y2szO JLWtzPkbUltH80OU4VWIOwZlBw== X-Google-Smtp-Source: ABdhPJyPZKwOiXzBHTbLo8u+XXGrcMTxLyckowlAbQAbLsvsVi6/QeKoKQtw13j+l9F3UB9MzsWBFg== X-Received: by 2002:a63:f19:: with SMTP id e25mr12833314pgl.220.1611208516174; Wed, 20 Jan 2021 21:55:16 -0800 (PST) Received: from [192.168.3.43] (cpe-66-75-72-126.hawaii.res.rr.com. [66.75.72.126]) by smtp.gmail.com with ESMTPSA id gg22sm4250906pjb.24.2021.01.20.21.55.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Jan 2021 21:55:15 -0800 (PST) Subject: Re: [PATCH 2/6] accel/tcg: Restrict tb_flush_jmp_cache() from other accelerators To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20210117164813.4101761-1-f4bug@amsat.org> <20210117164813.4101761-3-f4bug@amsat.org> From: Richard Henderson Message-ID: <2506bc48-6c1d-ab2f-eb6b-44ff9e1a5e34@linaro.org> Date: Wed, 20 Jan 2021 19:55:11 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210117164813.4101761-3-f4bug@amsat.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42e; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42e.google.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.094, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Riku Voipio , Eduardo Habkost , Huacai Chen , Claudio Fontana , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 1/17/21 6:48 AM, Philippe Mathieu-Daudé wrote: > tb_flush_jmp_cache() is only called within TCG accelerator, > declare it locally. > > Signed-off-by: Philippe Mathieu-Daudé > --- > We could also inline it in cputlb.c, the single user. > --- Yes, I think we should move it to cputlb.c. I have queued a patch to do so. r~