Re: [PATCH v2 02/10] target/openrisc: Explode MO_TExx -> MO_TE | MO_xx

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 9/10/25 18:43, Richard Henderson wrote:
> On 10/9/25 01:18, Philippe Mathieu-Daudé wrote:
>> Extract the implicit MO_TE definition in order to replace
>> it in the next commit.
>>
>> Mechanical change using:
>>
>>    $ for n in UW UL UQ UO SW SL SQ; do \
>>        sed -i -e "s/MO_TE$n/MO_TE | MO_$n/" \
>>             $(git grep -l MO_TE$n target/openrisc); \
>>      done
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   target/openrisc/translate.c | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> Why bother splitting, instead of just changing to MO_BEUL, etc?

In v3 I'll add a new patch introducing mo_endian(). Even if a target
is only build for a particular endianness (sometimes a QEMU limitation)
I think having an explicit mo_endian() is useful because 1/ only a
single place to look at / change if more endianness support added
and 2/ common style between our different targets. Therefore for
this patch I prefer a mechanical change before manual following ones.