Re: [PATCH RFC 0/1] To add HMP interface to dump PCI MSI-X table/PBA

[Jason Wang <jasowang@redhat.com>]

在 2021/4/23 下午12:47, Dongli Zhang 写道:
> This is inspired by the discussion with Jason on below patchset.
>
> https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg09020.html
>
> The new HMP command is introduced to dump the MSI-X table and PBA.
>
> Initially, I was going to add new option to "info pci". However, as the
> number of entries is not determined and the output of MSI-X table is much
> more similar to the output of hmp_info_tlb()/hmp_info_mem(), this patch
> adds interface for only HMP.
>
> The patch is tagged with RFC because I am looking for suggestions on:
>
> 1. Is it fine to add new "info msix <dev>" command?


I wonder the reason for not simply reusing "info pci"?


>
> 2. Is there any issue with output format?


If it's not for QMP, I guess it's not a part of ABI so it should be fine.


>
> 3. Is it fine to add only for HMP, but not QMP?


I think so.

Thanks


>
> Thank you very much!
>
> Dongli Zhang
>
>
>