From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNKTh-0003xG-Ui for qemu-devel@nongnu.org; Mon, 28 May 2018 11:54:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNKTd-0000u4-PR for qemu-devel@nongnu.org; Mon, 28 May 2018 11:54:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59098 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fNKTd-0000sa-K0 for qemu-devel@nongnu.org; Mon, 28 May 2018 11:54:29 -0400 References: <1527105041-21013-1-git-send-email-patryk@fala.ehost.pl> From: Paolo Bonzini Message-ID: <2518fb5e-a11e-10c8-7dcf-d53369c17ec6@redhat.com> Date: Mon, 28 May 2018 17:54:26 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] Remove unwanted crlf conversion in serial List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Patryk Olszewski , qemu-devel@nongnu.org Cc: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= On 24/05/2018 07:36, Thomas Huth wrote: > On 23.05.2018 21:50, Patryk Olszewski wrote: >> This patch fixes bug in serial that made it almost impossible for guest >> to communicate with devices through host's serial. >> >> OPOST flag in c_oflag enables output processing letting other flags in >> c_oflag take effect. Usually in c_oflag ONLCR flag is also set, which >> causes crlf to be sent in place of lf. This breaks binary transmissions. >> Unsetting OPOST flag turns off any output processing which fixes the bug. >> >> Bug reports related: >> https://bugs.launchpad.net/qemu/+bug/1772086 >> https://bugs.launchpad.net/qemu/+bug/1407813 >> https://bugs.launchpad.net/qemu/+bug/1715296 >> also >> https://lists.nongnu.org/archive/html/qemu-devel/2006-06/msg00196.html >> >> Signed-off-by: Patryk Olszewski >> --- >> chardev/char-serial.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/chardev/char-serial.c b/chardev/char-serial.c >> index feb52e5..ae548d2 100644 >> --- a/chardev/char-serial.c >> +++ b/chardev/char-serial.c >> @@ -139,7 +139,7 @@ static void tty_serial_init(int fd, int speed, >> >> tty.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP >> | INLCR | IGNCR | ICRNL | IXON); >> - tty.c_oflag |= OPOST; >> + tty.c_oflag &= ~OPOST; >> tty.c_lflag &= ~(ECHO | ECHONL | ICANON | IEXTEN | ISIG); >> tty.c_cflag &= ~(CSIZE | PARENB | PARODD | CRTSCTS | CSTOPB); >> switch (data_bits) { >> > > I think this bug has good chances to win the price "Oldest bug of the > year". If we'd wait one more months, it has its 15th anniversary: The > code has originally been added in 2003, see commit 0824d6fc674084519c85, > it has just been moved around to other files afterwards. Thus this is > almost as old as QEMU itself! It was also already fixed once in commit 64b7b7334b92c1fdc1bb7d3d1afc342656c59539 Author: aurel32 Date: Mon May 5 10:05:31 2008 +0000 Put Pseudo-TTY in rawmode for char devices (Daniel P. Berrange) Queued, thanks. Paolo