From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Greg Kurz <groug@kaod.org>, Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Richard Henderson <rth@twiddle.net>,
Collin Walling <walling@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Pierre Morel <pmorel@linux.ibm.com>,
qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 04/11] pci/pcie: stop plug/unplug if the slot is locked
Date: Mon, 7 Jan 2019 13:13:58 +0100 [thread overview]
Message-ID: <2527cf5c-983b-e4df-2c26-c47df87e6bf0@redhat.com> (raw)
In-Reply-To: <20181212091623.16950-5-david@redhat.com>
On 12.12.18 10:16, David Hildenbrand wrote:
> We better stop right away. For now, errors would be partially ignored
> (so the guest might get informed or the device might get unplugged),
> although actual plug/unplug will be reported as failed to the user.
>
> While at it, properly move the check to the pre_plug handler for the plug
> case, as we can test the slot state before the device will be realized.
>
> Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: David Hildenbrand <david@redhat.com>
@MST, looks like you missed this one.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-01-07 12:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 9:16 [Qemu-devel] [PATCH v4 00/11] pci: hotplug handler reworks David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 01/11] pci/pcie: rename hotplug handler callbacks David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 02/11] pci/shpc: " David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 03/11] s390x/pci: " David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 04/11] pci/pcie: stop plug/unplug if the slot is locked David Hildenbrand
2019-01-07 12:13 ` David Hildenbrand [this message]
2019-01-08 0:14 ` Michael S. Tsirkin
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 05/11] pci/pcihp: perform check for bus capability in pre_plug handler David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 06/11] pci/pcihp: overwrite hotplug handler recursively from the start David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 07/11] pci/pcihp: perform unplug via the hotplug handler David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 08/11] pci/pcie: " David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 09/11] pci: Reuse pci-bridge hotplug handler handlers for pcie-pci-bridge David Hildenbrand
2018-12-12 23:57 ` David Gibson
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 10/11] pci/shpc: perform unplug via the hotplug handler David Hildenbrand
2018-12-12 9:16 ` [Qemu-devel] [PATCH v4 11/11] spapr_pci: " David Hildenbrand
2018-12-17 13:46 ` [Qemu-devel] [PATCH v4 00/11] pci: hotplug handler reworks David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2527cf5c-983b-e4df-2c26-c47df87e6bf0@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).