From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 0/9] meson: Clarify summary
Date: Wed, 20 Jan 2021 18:10:53 +0100 [thread overview]
Message-ID: <25320ab3-1e26-8c24-2850-7cf8f6669492@redhat.com> (raw)
In-Reply-To: <20210119185005.880322-1-philmd@redhat.com>
On 19/01/21 19:49, Philippe Mathieu-Daudé wrote:
> Reorder stuffs in summary to quicker understand bug reports.
>
> Remove information from deselected features when not necessary.
>
> Philippe Mathieu-Daudé (9):
> meson: Summarize generic information first
> meson: Summarize compilation information altogether
> meson: Summarize host binaries altogether
> meson: Summarize accelerators altogether
> meson: Display if system emulation is selected in summary
> meson: Restrict system-mode specific accelerators
> meson: Do not configure audio if system-mode is not selected
> meson: Display if user-mode emulation is selected in summary
> meson: Summarize block layer information altogether
>
> configure | 6 +++
> meson.build | 132 +++++++++++++++++++++++++++++-----------------------
> 2 files changed, 81 insertions(+), 57 deletions(-)
>
Very nice. (I'm just not sure about patches 5 and 8 since there's
already the target directories). A couple nits:
* sparse should go in host binaries
* WIN_SDK should go in compilation information
* It would be nice to have a comment above each of the groups
I have done the changes myself. I will also send out for review a patch
to further group dependencies and "other features" (vhost, modules, etc.).
Paolo
prev parent reply other threads:[~2021-01-20 17:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 18:49 [PATCH 0/9] meson: Clarify summary Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 1/9] meson: Summarize generic information first Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 2/9] meson: Summarize compilation information altogether Philippe Mathieu-Daudé
2021-01-19 18:49 ` [PATCH 3/9] meson: Summarize host binaries altogether Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 4/9] meson: Summarize accelerators altogether Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 5/9] meson: Display if system emulation is selected in summary Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 6/9] meson: Restrict system-mode specific accelerators Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 7/9] meson: Do not configure audio if system-mode is not selected Philippe Mathieu-Daudé
2021-01-19 18:53 ` Philippe Mathieu-Daudé
2021-01-20 9:09 ` Gerd Hoffmann
2021-01-19 18:50 ` [PATCH 8/9] meson: Display if user-mode emulation is selected in summary Philippe Mathieu-Daudé
2021-01-19 18:50 ` [PATCH 9/9] meson: Summarize block layer information altogether Philippe Mathieu-Daudé
2021-01-20 17:10 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25320ab3-1e26-8c24-2850-7cf8f6669492@redhat.com \
--to=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).