From: Thomas Huth <thuth@redhat.com>
To: "Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Howard Spoelstra" <hsp.cat7@gmail.com>,
qemu-ppc@nongnu.org, "luigi burdo" <intermediadc@hotmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"QEMU Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI
Date: Fri, 24 Mar 2017 10:33:04 +0100 [thread overview]
Message-ID: <25901d9c-7539-3bc6-8372-9ab04d91c95b@redhat.com> (raw)
In-Reply-To: <81b9d4e2-92b2-4ab9-8e67-faf2dee8dc81@ilande.co.uk>
On 24.03.2017 09:56, Mark Cave-Ayland wrote:
> On 24/03/17 08:47, Howard Spoelstra wrote:
>
>> Hi,
>>
>> Running qemu-system-ppc.exe in windows with the SDL2 GUI results in a
>> hangup. I bisected to this commit:
>>
>> 8bb93c6f99a42c2e0943bc904b283cd622d302c5 is the first bad commit
>> commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5
>> Author: Alex Bennée <alex.bennee@linaro.org>
>> Date: Wed Mar 15 14:48:25 2017 +0000
>>
>> ui/console: ensure graphic updates don't race with TCG vCPUs
>>
>> Commit 8d04fb55..
>>
>> tcg: drop global lock during TCG code execution
>>
>> ..broke the assumption that updates to the GUI couldn't happen at the
>> same time as TCG vCPUs where running. As a result the TCG vCPU could
>> still be updating a directly mapped frame-buffer while the display
>> side was updating. This would cause artefacts to appear when the
>> update code assumed that memory block hadn't changed.
>>
>> The simplest solution is to ensure the two things can't happen at the
>> same time like the old BQL locking scheme. Here we use the solution
>> introduced for MTTCG and schedule the update as async_safe_work when
>> we know no vCPUs can be running.
>>
>> Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Message-id: 20170315144825.3108-1-alex.bennee@linaro.org
>> Cc: BALATON Zoltan <balaton@eik.bme.hu>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> [ kraxel: updated comment clarifying the display adapters are buggy
>> and this is a temporary workaround ]
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Hi Howard,
>
> Alex posted another patch yesterday to resolve a similar issue:
> https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg04474.html.
>
> Does applying the above patch help at all?
Luigi Burdo reported a similar issue here:
https://bugs.launchpad.net/qemu/+bug/1675549
Luigi, could you please try Alex' patch to see whether it fixes your crash?
Thanks,
Thomas
next parent reply other threads:[~2017-03-24 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABLmASH=JA8qh+bqNjHiAB_hwbxZ-DnA4fy5tgu8+THbwvM7zg@mail.gmail.com>
[not found] ` <81b9d4e2-92b2-4ab9-8e67-faf2dee8dc81@ilande.co.uk>
2017-03-24 9:33 ` Thomas Huth [this message]
2017-03-24 10:06 ` [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI luigi burdo
2017-03-27 17:10 ` luigi burdo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25901d9c-7539-3bc6-8372-9ab04d91c95b@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=hsp.cat7@gmail.com \
--cc=intermediadc@hotmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).