qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>,
	qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] S390: Bail out whithout KVM
Date: Fri, 18 Dec 2009 22:05:44 +0100	[thread overview]
Message-ID: <25EB805F-FD36-4AA4-A2DB-BCF1F59FCDDE@web.de> (raw)
In-Reply-To: <1261150144-1702-1-git-send-email-agraf@suse.de>

Hi,

Am 18.12.2009 um 16:29 schrieb Alexander Graf:

> Currently only the S390 KVM target works. To keep users from  
> accidently not
> using KVM, let's not even initialize the machine when KVM is not used.

How does this fit together with your "S390 TCG target" patch? Aren't  
they mutually exclusive?  Is this one for stable?

Andreas

> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> hw/s390-virtio.c |    7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
> index b57fa9c..a33076a 100644
> --- a/hw/s390-virtio.c
> +++ b/hw/s390-virtio.c
> @@ -142,6 +142,13 @@ static void s390_init(ram_addr_t ram_size,
>     ram_addr_t initrd_size = 0;
>     int i;
>
> +    /* XXX we only work on KVM for now */
> +
> +    if (!kvm_enabled()) {
> +        fprintf(stderr, "The S390 target only works with KVM enabled 
> \n");
> +        exit(1);
> +    }
> +
>     /* get a BUS */
>     s390_bus = s390_virtio_bus_init(&ram_size);
>
> -- 
> 1.6.0.2
>
>
>

  reply	other threads:[~2009-12-18 21:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-18 15:29 [Qemu-devel] [PATCH] S390: Bail out whithout KVM Alexander Graf
2009-12-18 21:05 ` Andreas Färber [this message]
2009-12-18 21:07   ` Alexander Graf
2009-12-18 21:23     ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25EB805F-FD36-4AA4-A2DB-BCF1F59FCDDE@web.de \
    --to=andreas.faerber@web.de \
    --cc=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=cotte@de.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).