From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <fam@euphon.net>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] virtio-scsi: restart DMA after iothread
Date: Mon, 17 Jun 2019 19:23:41 +0200 [thread overview]
Message-ID: <25ad60d8-8860-b535-a42b-03d4d63d0802@redhat.com> (raw)
In-Reply-To: <20190617122922.GG7397@linux.fritz.box>
On 17/06/19 14:29, Kevin Wolf wrote:
> But in the end, if Paolo feels strongly that for whatever reason
> propagating events through the real device tree isn't good, let's get
> the bug fixed with whatever hack it takes.
It is actually good, but the implementation in hw/scsi is ugly because
it singles out virtio-scsi - whereas the rule should simply be that the
HBA is stopped after the disks and started before. Having the HBA do
something special if it cares about the order is the part that I didn't
like.
Paolo
next prev parent reply other threads:[~2019-06-17 17:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 12:04 [Qemu-devel] [PATCH v4] virtio-scsi: restart DMA after iothread Stefan Hajnoczi
2019-06-12 12:32 ` Paolo Bonzini
2019-06-12 14:06 ` no-reply
2019-06-17 12:29 ` Kevin Wolf
2019-06-17 17:23 ` Paolo Bonzini [this message]
2019-06-17 17:58 ` Kevin Wolf
2019-06-17 18:27 ` Paolo Bonzini
2019-06-20 16:18 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ad60d8-8860-b535-a42b-03d4d63d0802@redhat.com \
--to=pbonzini@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).