Re: [PATCH v1 7/7] gdbstub: fix compiler complaining

["Philippe Mathieu-Daudé" <philmd@redhat.com>]

On 3/27/20 10:49 AM, Alex Bennée wrote:
> From: Denis Plotnikov <dplotnikov@virtuozzo.com>
> 
>      ./gdbstub.c: In function ‘handle_query_thread_extra’:
>          /usr/include/glib-2.0/glib/glib-autocleanups.h:28:10:
>      error: ‘cpu_name’ may be used uninitialized in this function
>      [-Werror=maybe-uninitialized]
>          g_free (*pp);
>                 ^
>      ./gdbstub.c:2063:26: note: ‘cpu_name’ was declared here
>          g_autofree char *cpu_name;
>                           ^
>      cc1: all warnings being treated as errors
> 
> Signed-off-by: Denis Plotnikov <dplotnikov@virtuozzo.com>
> Message-Id: <20200326151407.25046-1-dplotnikov@virtuozzo.com>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Reported-by: Chen Qun <kuhn.chenqun@huawei.com>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   gdbstub.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 013fb1ac0f1..171e1509509 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -2060,8 +2060,8 @@ static void handle_query_thread_extra(GdbCmdContext *gdb_ctx, void *user_ctx)
>           /* Print the CPU model and name in multiprocess mode */
>           ObjectClass *oc = object_get_class(OBJECT(cpu));
>           const char *cpu_model = object_class_get_name(oc);
> -        g_autofree char *cpu_name;
> -        cpu_name  = object_get_canonical_path_component(OBJECT(cpu));
> +        g_autofree char *cpu_name =
> +            object_get_canonical_path_component(OBJECT(cpu));
>           g_string_printf(rs, "%s %s [%s]", cpu_model, cpu_name,
>                           cpu->halted ? "halted " : "running");
>       } else {
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>