Re: [PATCH v2 2/2] pnv/psi: Initialize the PSIHB interrupts to match hardware

["Cédric Le Goater" <clg@kaod.org>]

On 7/3/23 10:12, Frederic Barrat wrote:
> On the powernv9 and powernv10 machines, the PSIHB interrupts are
> currently initialized with a PQ state of 0b01, i.e. interrupts are
> disabled. However real hardware initializes them to 0b00 for the
> PSIHB. This patch updates it, in case an hypervisor is in the mood of
> checking it.
> 
> Signed-off-by: Frederic Barrat <fbarrat@linux.ibm.com>


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   hw/ppc/pnv_psi.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c
> index 46da58dff8..daaa2f0575 100644
> --- a/hw/ppc/pnv_psi.c
> +++ b/hw/ppc/pnv_psi.c
> @@ -863,6 +863,8 @@ static void pnv_psi_power9_realize(DeviceState *dev, Error **errp)
>       object_property_set_int(OBJECT(xsrc), "nr-irqs", PSIHB9_NUM_IRQS,
>                               &error_fatal);
>       object_property_set_link(OBJECT(xsrc), "xive", OBJECT(psi), &error_abort);
> +    object_property_set_int(OBJECT(xsrc), "reset-pq", XIVE_ESB_RESET,
> +                            &error_abort);
>       if (!qdev_realize(DEVICE(xsrc), NULL, errp)) {
>           return;
>       }