From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0C78EB64DC for ; Mon, 3 Jul 2023 08:24:22 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qGEr3-0005yQ-OV; Mon, 03 Jul 2023 04:24:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGEr0-0005qA-Q1; Mon, 03 Jul 2023 04:24:15 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGEqz-0006ml-8d; Mon, 03 Jul 2023 04:24:14 -0400 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4Qvf8p6xLNz4wZp; Mon, 3 Jul 2023 18:24:10 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Qvf8n3vW5z4wZJ; Mon, 3 Jul 2023 18:24:09 +1000 (AEST) Message-ID: <25c6a049-040d-a63c-1f9d-484b92aed83c@kaod.org> Date: Mon, 3 Jul 2023 10:24:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/2] pnv/psi: Initialize the PSIHB interrupts to match hardware Content-Language: en-US To: Frederic Barrat , Daniel Henrique Barboza , qemu-ppc@nongnu.org, qemu-devel@nongnu.org References: <20230703081215.55252-1-fbarrat@linux.ibm.com> <20230703081215.55252-3-fbarrat@linux.ibm.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <20230703081215.55252-3-fbarrat@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=mKPa=CV=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.09, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 7/3/23 10:12, Frederic Barrat wrote: > On the powernv9 and powernv10 machines, the PSIHB interrupts are > currently initialized with a PQ state of 0b01, i.e. interrupts are > disabled. However real hardware initializes them to 0b00 for the > PSIHB. This patch updates it, in case an hypervisor is in the mood of > checking it. > > Signed-off-by: Frederic Barrat Reviewed-by: Cédric Le Goater Thanks, C. > --- > hw/ppc/pnv_psi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/pnv_psi.c b/hw/ppc/pnv_psi.c > index 46da58dff8..daaa2f0575 100644 > --- a/hw/ppc/pnv_psi.c > +++ b/hw/ppc/pnv_psi.c > @@ -863,6 +863,8 @@ static void pnv_psi_power9_realize(DeviceState *dev, Error **errp) > object_property_set_int(OBJECT(xsrc), "nr-irqs", PSIHB9_NUM_IRQS, > &error_fatal); > object_property_set_link(OBJECT(xsrc), "xive", OBJECT(psi), &error_abort); > + object_property_set_int(OBJECT(xsrc), "reset-pq", XIVE_ESB_RESET, > + &error_abort); > if (!qdev_realize(DEVICE(xsrc), NULL, errp)) { > return; > }