qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Jiahui Cen <cenjiahui@huawei.com>, qemu-devel@nongnu.org
Cc: xieyingtai@huawei.com, peter.maydell@linaro.org,
	berrange@redhat.com, mst@redhat.com, xiexiangyou@huawei.com,
	shannon.zhaosl@gmail.com, miaoyubo@huawei.com,
	"Gerd Hoffmann" <kraxel@redhat.com>,
	imammedo@redhat.com, "Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg
Date: Wed, 4 Nov 2020 21:05:24 +0100	[thread overview]
Message-ID: <25c7d6a0-98e4-6287-2da3-bbdf9836fb95@redhat.com> (raw)
In-Reply-To: <dadc89f2-bff2-358a-b15d-1302018286a5@redhat.com>

+Phil, +Gerd

On 11/04/20 20:54, Laszlo Ersek wrote:
> +Marcel
> 
> On 11/03/20 13:01, Jiahui Cen wrote:
>> From: Yubo Miao <miaoyubo@huawei.com>
>>
>> Write the extra roots into the fw_cfg, therefore the uefi could
>> get the extra roots. Only if the uefi knows there are extra roots,
>> the config space of devices behind the root could be obtained.
>>
>> Signed-off-by: Yubo Miao <miaoyubo@huawei.com>
>> Signed-off-by: Jiahui Cen <cenjiahui@huawei.com>
>> ---
>>  hw/arm/virt.c              |  8 ++++++++
>>  hw/i386/pc.c               | 18 ++----------------
>>  hw/nvram/fw_cfg.c          | 20 ++++++++++++++++++++
>>  include/hw/nvram/fw_cfg.h  |  2 ++
>>  include/hw/pci/pcie_host.h |  4 ++++
>>  5 files changed, 36 insertions(+), 16 deletions(-)

I realize I never reacted to this patch before (and we're at v9), so you
might not welcome my feedback at this point.

The explanation why I've only reacted now is the following: there's an
agreement between Phil and myself that Phil handles fw_cfg reviews
primarily, and I review only (or almost only) Phil's patches for fw_cfg.
Furthermore, all versions of this particular patch, as far as I can see,
CC'd me but not Phil. So Phil never knew to look, and I never checked
(this being an fw_cfg patch, per subject line) beyond the author being
Phil or not.

The solution is of course to use the get_maintainer.pl script for
determining reviewers, and adding them with "Cc:" tags to the commit
message. (You also missed Marcel at the least; see my previous
response.) git-send-email is supposed to adhere to those "Cc:" tags.

The reason I've looked now is... I guess I was too tired to remember our
agreement with Phil.

Thanks
Laszlo



  reply	other threads:[~2020-11-04 20:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 12:01 [PATCH v9 0/8] pci_expander_brdige:acpi: Support pxb-pcie for ARM Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 1/8] acpi: Extract two APIs from acpi_dsdt_add_pci Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 2/8] fw_cfg: Write the extra roots into the fw_cfg Jiahui Cen
2020-11-04 19:54   ` Laszlo Ersek
2020-11-04 20:05     ` Laszlo Ersek [this message]
2020-11-04 21:11       ` Philippe Mathieu-Daudé
2020-11-05  3:07         ` Jiahui Cen
2020-11-05  3:07       ` Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 3/8] acpi: Extract crs build form acpi_build.c Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 4/8] acpi: Refactor the source of host bridge and build tables for pxb Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 5/8] acpi: Align the size to 128k Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 6/8] unit-test: The files changed Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 7/8] unit-test: Add testcase for pxb Jiahui Cen
2020-11-03 12:01 ` [PATCH v9 8/8] unit-test: Add the binary file and clear diff.h Jiahui Cen
2020-11-05  7:35 ` [PATCH v9 0/8] pci_expander_brdige:acpi: Support pxb-pcie for ARM Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25c7d6a0-98e4-6287-2da3-bbdf9836fb95@redhat.com \
    --to=lersek@redhat.com \
    --cc=berrange@redhat.com \
    --cc=cenjiahui@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=miaoyubo@huawei.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shannon.zhaosl@gmail.com \
    --cc=xiexiangyou@huawei.com \
    --cc=xieyingtai@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).