From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
armbru@redhat.com, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header
Date: Thu, 8 Aug 2019 10:31:03 -0700 [thread overview]
Message-ID: <25d1668b-1256-2ba6-0fce-d8675e21f43f@linaro.org> (raw)
In-Reply-To: <20190808164117.23348-3-alex.bennee@linaro.org>
On 8/8/19 9:41 AM, Alex Bennée wrote:
> +static inline void set_float_detect_tininess(int val, float_status *status)
> +{
> + status->float_detect_tininess = val;
> +}
> +static inline void set_float_rounding_mode(int val, float_status *status)
> +{
> + status->float_rounding_mode = val;
> +}
> +static inline void set_float_exception_flags(int val, float_status *status)
> +{
> + status->float_exception_flags = val;
> +}
Can you please fix the spacing at the same time? Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-08-08 17:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 16:41 [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types Alex Bennée
2019-08-08 17:28 ` Richard Henderson
2019-08-09 10:08 ` Peter Maydell
2019-08-10 10:03 ` Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header Alex Bennée
2019-08-08 17:31 ` Richard Henderson [this message]
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 3/7] fpu: make softfloat-macros "self-contained" Alex Bennée
2019-08-08 17:49 ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 4/7] fpu: rename softfloat-specialize.h -> .inc.c Alex Bennée
2019-08-08 17:50 ` Richard Henderson
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes Alex Bennée
2019-08-08 17:55 ` Richard Henderson
2019-08-09 8:33 ` Alex Bennée
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 6/7] target/riscv: " Alex Bennée
2019-08-08 17:57 ` Richard Henderson
2019-08-10 1:55 ` Alistair Francis
2019-08-08 16:41 ` [Qemu-devel] [PATCH v1 7/7] targets (various): use softfloat-helpers.h where we can Alex Bennée
2019-08-08 17:58 ` Richard Henderson
2019-08-09 8:58 ` David Hildenbrand
2019-08-08 16:58 ` [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups no-reply
2019-08-08 17:41 ` no-reply
2019-08-08 18:02 ` no-reply
2019-08-08 18:49 ` no-reply
2019-08-09 6:31 ` Markus Armbruster
2019-08-09 8:20 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25d1668b-1256-2ba6-0fce-d8675e21f43f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).