From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 093CBC433DB for ; Tue, 16 Feb 2021 17:34:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E18C64E07 for ; Tue, 16 Feb 2021 17:34:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E18C64E07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC4Ed-0007dD-6A for qemu-devel@archiver.kernel.org; Tue, 16 Feb 2021 12:34:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC4C1-0006N2-7h for qemu-devel@nongnu.org; Tue, 16 Feb 2021 12:31:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37954) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lC4Bx-00085u-UD for qemu-devel@nongnu.org; Tue, 16 Feb 2021 12:31:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613496675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0R/REM+fkNYSL2EOeATww8cUnuH/U9oV46Z8IZCblDU=; b=OqExFYnRfn4EZVLQ7tsK62UICCiz1cJL+z16+1o82RDIEPe3QNjz/dJOuglAPE5j2Poo/W h1CHpoGgJnDEY/qqifIFQMFtN/H8KwgaoqVajE2yXYRjWFTYLAr7jG6YjV7XIA1Ud31/sg o2C/SJwdbtf5dRaYjstLbYRHuo1DrX4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-YgLaYEl4PIqhTf2pqpUKng-1; Tue, 16 Feb 2021 12:31:12 -0500 X-MC-Unique: YgLaYEl4PIqhTf2pqpUKng-1 Received: by mail-wr1-f69.google.com with SMTP id e11so13325847wro.19 for ; Tue, 16 Feb 2021 09:31:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0R/REM+fkNYSL2EOeATww8cUnuH/U9oV46Z8IZCblDU=; b=NpN9M7BfA6sZQueOa4fUafPul19vArVdA1saqvqnlmKe/vSa/fxw+iZDg58PbPb8Cl 3UPE8j8YfTSVBtxfCgxkUrBcVbVoxXtcOMYEsUAZ+omNL/D/U+BEIZW+aooQHz0cX18X XxQ5DgmNdI+7gLI90mIPjveIx/cV3BwpCujDn9ibrGna6D9xBw/+vze6vN+/4EpGnFeR C51ca8MCWuY5qxIlOR9RnwA5TlC6Ba8RsL/dSPNXHyBaZyqmFrGj48ClvTzj9dDJ56Hc PridvuIR+pob8DcOMbPC+yAJ9oHq7RzW6aqRLITQiYQ++Y25pQ8SuX4ePmfzcstT4AGN WiNQ== X-Gm-Message-State: AOAM532JkW+VcYTFkQsYExlqG1u0oq4x/AgVyzS6z1TNhPaW3ZGfnin8 O9sIYDA9bmHFafrD76nZrtNk9mnZSG7h9UULcFKG5+t11RawQJRxbOg9y0tWX1k/gHsK9GsXFv6 tOhEUeGbE9MKNgnqaEwynuk0lGccQuoHPGbNa5gn7ozAFfSk7q4LLUh69nfpIKdba X-Received: by 2002:a1c:2090:: with SMTP id g138mr4038823wmg.137.1613496670695; Tue, 16 Feb 2021 09:31:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKycXNNJh3qQlfqSXMUKLEWnNTnikgQNu6Zm2K2kGNxVHYqF8q7SP+BeOtBqaHPn/T5vWx1g== X-Received: by 2002:a1c:2090:: with SMTP id g138mr4038799wmg.137.1613496670312; Tue, 16 Feb 2021 09:31:10 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id h18sm17073989wrm.54.2021.02.16.09.31.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Feb 2021 09:31:09 -0800 (PST) Subject: Re: [PATCH] qtest: add a reproducer for LP#1878642 To: Alexander Bulekov , Peter Maydell References: <20201102163336.115444-1-alxndr@bu.edu> <20210216150025.ujuq7cxspep2kaei@mozz.bu.edu> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <25d3918d-913b-a2c6-209f-92732002e823@redhat.com> Date: Tue, 16 Feb 2021 18:31:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210216150025.ujuq7cxspep2kaei@mozz.bu.edu> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Paolo Bonzini , Thomas Huth , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/16/21 4:00 PM, Alexander Bulekov wrote: > On 210216 1325, Peter Maydell wrote: >> On Mon, 2 Nov 2020 at 16:35, Alexander Bulekov wrote: >>> >>> https://bugs.launchpad.net/qemu/+bug/1878642 >>> >>> Suggested-by: Paolo Bonzini >>> Signed-off-by: Alexander Bulekov >>> --- >>> >>> Based-on: <20200717151705.18611-1-f4bug@amsat.org> >>> >>> The added testcase will fail, unless this ^^^ patch is applied. >>> >>> tests/qtest/fuzz-test.c | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/tests/qtest/fuzz-test.c b/tests/qtest/fuzz-test.c >>> index 2f38bb1ec2..9cb4c42bde 100644 >>> --- a/tests/qtest/fuzz-test.c >>> +++ b/tests/qtest/fuzz-test.c >>> @@ -34,6 +34,19 @@ static void test_lp1878263_megasas_zero_iov_cnt(void) >>> qtest_quit(s); >>> } >>> >>> +static void test_lp1878642_pci_bus_get_irq_level_assert(void) >>> +{ >>> + QTestState *s; >>> + >>> + s = qtest_init("-M pc-q35-5.0 " >>> + "-nographic -monitor none -serial none " >>> + "-d guest_errors -trace pci*"); >>> + >>> + qtest_outl(s, 0xcf8, 0x8400f841); >>> + qtest_outl(s, 0xcfc, 0xebed205d); >>> + qtest_outl(s, 0x5d02, 0xebed205d); >>> +} >> >> Hi; I just noticed this, but why does this test case pass >> "-trace pci*" to QEMU? It doesn't look like it does anything to >> try to capture the trace output, which thus winds up just going >> to the stdout/stderr of the "make check" run. Similarly I'm not >> sure '-d guest_errors' is going to do anything helpful unless >> you take steps to capture the output and check it. I suppose Alex took it from commit 4177b062fc5 ("hw/isa/lpc_ich9: Ignore reserved/invalid SCI IRQ") where it is used to show the problem the fuzzer reproducer triggers. Not useful in regular testing. > Ah, I sometimes include those in the initial report, if the device has > trace-events. I can remove this from fuzz-test.c, if it is slowing > things down. I doubt it is slowing things down, but it probably make it harder to find other problems (I suppose Peter got confused when looking for another failure and found these traces).