From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Janosch Frank" <frankja@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH v4 2/7] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size()
Date: Fri, 24 Feb 2023 08:01:00 +0100 [thread overview]
Message-ID: <25deaa40-fe58-f7c5-6098-20c938b85e8e@redhat.com> (raw)
In-Reply-To: <20230223231755.81633-3-philmd@linaro.org>
On 24/02/2023 00.17, Philippe Mathieu-Daudé wrote:
> TARGET_PAGE_SIZE is target specific. In preparation of
> making dump.c target-agnostic, replace the compile-time
> TARGET_PAGE_SIZE definition by runtime qemu_target_page_size().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> dump/dump.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/dump/dump.c b/dump/dump.c
> index 7101169ecb..3784a9054d 100644
> --- a/dump/dump.c
> +++ b/dump/dump.c
> @@ -15,6 +15,7 @@
> #include "qemu/cutils.h"
> #include "elf.h"
> #include "exec/hwaddr.h"
> +#include "exec/target_page.h"
> #include "monitor/monitor.h"
> #include "sysemu/kvm.h"
> #include "sysemu/dump.h"
> @@ -1859,7 +1860,7 @@ static void dump_init(DumpState *s, int fd, bool has_format,
> }
>
> if (!s->dump_info.page_size) {
> - s->dump_info.page_size = TARGET_PAGE_SIZE;
> + s->dump_info.page_size = qemu_target_page_size();
> }
>
> s->note_size = cpu_get_note_size(s->dump_info.d_class,
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-02-24 7:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 23:17 [PATCH v4 0/7] dump: Make most of it target agnostic (build once) Philippe Mathieu-Daudé
2023-02-23 23:17 ` [PATCH v4 1/7] dump: Replace tswapN() -> cpu_to_dumpN() Philippe Mathieu-Daudé
2023-02-23 23:29 ` Richard Henderson
2023-02-24 7:00 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 2/7] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() Philippe Mathieu-Daudé
2023-02-23 23:30 ` Richard Henderson
2023-02-24 7:01 ` Thomas Huth [this message]
2023-02-23 23:17 ` [PATCH v4 3/7] dump: Correct headers included Philippe Mathieu-Daudé
2023-02-23 23:32 ` Richard Henderson
2023-02-24 7:02 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 4/7] dump: Introduce win_dump_available() Philippe Mathieu-Daudé
2023-02-23 23:43 ` Richard Henderson
2023-02-24 7:08 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 5/7] dump: Introduce create_win_dump() Philippe Mathieu-Daudé
2023-02-23 23:43 ` Richard Henderson
2023-02-24 7:08 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 6/7] dump: Build once by adding stubs for non-x86 targets Philippe Mathieu-Daudé
2023-02-23 23:51 ` Richard Henderson
2023-02-24 6:53 ` Philippe Mathieu-Daudé
2023-02-23 23:17 ` [PATCH v4 7/7] dump: Rename x86-specific file as win_dump_x86.c Philippe Mathieu-Daudé
2023-02-23 23:22 ` Philippe Mathieu-Daudé
2023-02-23 23:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25deaa40-fe58-f7c5-6098-20c938b85e8e@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=frankja@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).