From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eoszF-0003iP-Pu for qemu-devel@nongnu.org; Thu, 22 Feb 2018 10:40:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eoszA-0000pk-T2 for qemu-devel@nongnu.org; Thu, 22 Feb 2018 10:40:45 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43874) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eoszA-0000oe-Jw for qemu-devel@nongnu.org; Thu, 22 Feb 2018 10:40:40 -0500 Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1MFd0Gh028882 for ; Thu, 22 Feb 2018 10:40:39 -0500 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g9xua5pme-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 22 Feb 2018 10:40:38 -0500 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Feb 2018 08:40:37 -0700 References: <1519241752-28083-1-git-send-email-walling@linux.vnet.ibm.com> <29048432-906e-5fbe-d927-0814b0c24e4d@de.ibm.com> From: "Collin L. Walling" Date: Thu, 22 Feb 2018 10:40:32 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Message-Id: <25e410d1-3b6a-1178-d46c-87f247eacea9@linux.vnet.ibm.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Viktor Mihajlovski , Christian Borntraeger , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Cc: frankja@linux.vnet.ibm.com, thuth@redhat.com, cohuck@redhat.com, david@redhat.com, alifm@linux.vnet.ibm.com, eblake@redhat.com On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: > On 22.02.2018 12:51, Christian Borntraeger wrote: >> Series >> Acked-by: Christian Borntraeger Thanks!!! >> >> >> menu on scsi and dasd bootmaps tested successfully. >> >> There is one thing that we might want to fix (can be an addon patch si= nce this is a non-customer >> scenario (no libvirt)). >> >> If you start QEMU manually without a bootindex, the -boot menu=3Don is= ignored >> if no drive has a bootindex. >> >> For example: >> >> -drive file=3D/dev/dasda,if=3Dnone,id=3Dd1 -device virtio-blk-ccw,driv= e=3Dd1,bootindex=3D1 -boot menu=3Don >> does work >> >> -drive file=3D/dev/dasda -boot menu=3Don >> does not >> >> instead it prints: >> qemu-system-s390x: boot menu is not supported for this device type. >> >> and the boots up the default entry. >> > That should indeed be a separate patch, as it would move logic currentl= y > in the BIOS up to QEMU (find the first defined virtio disk and select i= t > as boot disk). > In fact it's more complicated than that, because it would have to > properly account for -boot order=3D[acdn] and produce the respective IP= LB. > While it makes sense, I wouldn't rush that in but rather change the > error message to indicate that -device bootindex is needed to activate > the menu, at least for the time being. > [...] > I can look into it.=C2=A0 Theoretically, the easier fix should just invol= ve=20 parsing all of the -device commands and looking for a "bootindex=3D1" field. The Qemu= =20 options code already handles a bulk of this work, so it's just a matter of=20 putting it all together. Shall I whip something up and post what I have as a reply to this email=20 chain? --=20 - Collin L Walling