From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Maxim Levitsky <mlevitsk@redhat.com>
Subject: Re: [PATCH] block/amend: Check whether the node exists
Date: Fri, 24 Jul 2020 09:08:13 +0200 [thread overview]
Message-ID: <25e91a23-807b-04ff-05e7-4842de206dc3@redhat.com> (raw)
In-Reply-To: <20200710095037.10885-1-mreitz@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 550 bytes --]
On 10.07.20 11:50, Max Reitz wrote:
> We should check whether the user-specified node-name actually refers to
> a node. The simplest way to do that is to use bdrv_lookup_bs() instead
> of bdrv_find_node() (the former wraps the latter, and produces an error
> message if necessary).
>
> Reported-by: Coverity (CID 1430268)
> Fixes: ced914d0ab9fb2c900f873f6349a0b8eecd1fdbe
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> block/amend.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Applied to my block branch.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-07-24 7:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 9:50 [PATCH] block/amend: Check whether the node exists Max Reitz
2020-07-12 11:47 ` Maxim Levitsky
2020-07-23 17:56 ` Peter Maydell
2020-07-24 7:01 ` Max Reitz
2020-07-24 7:08 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25e91a23-807b-04ff-05e7-4842de206dc3@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).