* [RFC PATCH] linux-user: ensure nios2 processes queued work
@ 2024-02-20 17:08 Alex Bennée
2024-02-20 18:54 ` Philippe Mathieu-Daudé
2024-02-20 19:08 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Alex Bennée @ 2024-02-20 17:08 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Laurent Vivier
While async processes are rare for linux-user we do use them from time
to time. The most obvious one is tb_flush when we run out of
translation space. We will also need this when we move plugin
vcpu_init to an async task.
Fix nios2 to follow its older, wiser and more stable siblings.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
linux-user/nios2/cpu_loop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
index da77ede76bd..7fe08c87501 100644
--- a/linux-user/nios2/cpu_loop.c
+++ b/linux-user/nios2/cpu_loop.c
@@ -32,6 +32,7 @@ void cpu_loop(CPUNios2State *env)
cpu_exec_start(cs);
trapnr = cpu_exec(cs);
cpu_exec_end(cs);
+ process_queued_cpu_work(cs);
switch (trapnr) {
case EXCP_INTERRUPT:
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] linux-user: ensure nios2 processes queued work
2024-02-20 17:08 [RFC PATCH] linux-user: ensure nios2 processes queued work Alex Bennée
@ 2024-02-20 18:54 ` Philippe Mathieu-Daudé
2024-02-20 19:08 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-02-20 18:54 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Laurent Vivier
On 20/2/24 18:08, Alex Bennée wrote:
> While async processes are rare for linux-user we do use them from time
> to time. The most obvious one is tb_flush when we run out of
> translation space. We will also need this when we move plugin
> vcpu_init to an async task.
>
> Fix nios2 to follow its older, wiser and more stable siblings.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> linux-user/nios2/cpu_loop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
> index da77ede76bd..7fe08c87501 100644
> --- a/linux-user/nios2/cpu_loop.c
> +++ b/linux-user/nios2/cpu_loop.c
> @@ -32,6 +32,7 @@ void cpu_loop(CPUNios2State *env)
> cpu_exec_start(cs);
> trapnr = cpu_exec(cs);
> cpu_exec_end(cs);
> + process_queued_cpu_work(cs);
We really should abstract that pattern for user emulation.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] linux-user: ensure nios2 processes queued work
2024-02-20 17:08 [RFC PATCH] linux-user: ensure nios2 processes queued work Alex Bennée
2024-02-20 18:54 ` Philippe Mathieu-Daudé
@ 2024-02-20 19:08 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2024-02-20 19:08 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Laurent Vivier
On 2/20/24 07:08, Alex Bennée wrote:
> While async processes are rare for linux-user we do use them from time
> to time. The most obvious one is tb_flush when we run out of
> translation space. We will also need this when we move plugin
> vcpu_init to an async task.
>
> Fix nios2 to follow its older, wiser and more stable siblings.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
> linux-user/nios2/cpu_loop.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-20 19:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-20 17:08 [RFC PATCH] linux-user: ensure nios2 processes queued work Alex Bennée
2024-02-20 18:54 ` Philippe Mathieu-Daudé
2024-02-20 19:08 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).