From: Stefan Berger <stefanb@linux.ibm.com>
To: Ard Biesheuvel <ardb@kernel.org>,
Shannon Zhao <shannon.zhaosl@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
gshan@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Eric Auger <eric.auger@redhat.com>,
qemu-arm@nongnu.org, marcandre.lureau@redhat.com,
imammedo@redhat.com, Laszlo Ersek <lersek@redhat.com>,
eric.auger.pro@gmail.com
Subject: Re: [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT
Date: Fri, 8 May 2020 15:15:48 -0400 [thread overview]
Message-ID: <260618f0-a6f5-0a5a-2174-f3e33fd221b5@linux.ibm.com> (raw)
In-Reply-To: <CAMj1kXHHn9mbowEzEf3O3L7eC=e5zY3w2CqzK2qop19kKRDa=A@mail.gmail.com>
On 5/8/20 11:25 AM, Ard Biesheuvel wrote:
> On Fri, 8 May 2020 at 17:24, Shannon Zhao <shannon.zhaosl@gmail.com> wrote:
>> Hi,
>>
>> On 2020/5/5 22:44, Eric Auger wrote:
>>> +static void acpi_dsdt_add_tpm(Aml *scope, VirtMachineState *vms)
>>> +{
>>> + hwaddr pbus_base = vms->memmap[VIRT_PLATFORM_BUS].base;
>>> + PlatformBusDevice *pbus = PLATFORM_BUS_DEVICE(vms->platform_bus_dev);
>>> + MemoryRegion *sbdev_mr;
>>> + SysBusDevice *sbdev;
>>> + hwaddr tpm_base;
>>> +
>>> + sbdev = (SysBusDevice *)object_dynamic_cast(OBJECT(tpm_find()),
>>> + TYPE_SYS_BUS_DEVICE);
>> Does it need to check the tpm version like you do in previous patch?
>>
>> tpm_get_version(tpm_find()) == TPM_VERSION_2_0
>>
> I don't think so. The device node could in theory be used to describe
> a TPM 1.2/1.3 as well, even though we never actually do that.
There is no TPM 1.3. There may be a TIS v1.3.
next prev parent reply other threads:[~2020-05-08 19:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 14:44 [PATCH v2 0/3] vTPM/aarch64 ACPI support Eric Auger
2020-05-05 14:44 ` [PATCH v2 1/3] acpi: Move build_tpm2() in the generic part Eric Auger
2020-05-05 16:17 ` Stefan Berger
2020-05-06 6:33 ` Andrew Jones
2020-05-06 9:50 ` Auger Eric
2020-05-12 14:10 ` Igor Mammedov
2020-05-12 14:56 ` Auger Eric
2020-05-06 9:58 ` Michael S. Tsirkin
2020-05-12 14:14 ` Igor Mammedov
2020-05-12 15:59 ` Auger Eric
2020-05-14 9:53 ` Igor Mammedov
2020-05-05 14:44 ` [PATCH v2 2/3] arm/acpi: TPM2 ACPI table support Eric Auger
2020-05-05 16:16 ` Stefan Berger
2020-05-12 14:27 ` Igor Mammedov
2020-05-12 16:06 ` Auger Eric
2020-05-05 14:44 ` [PATCH v2 3/3] arm/acpi: Add the TPM2.0 device under the DSDT Eric Auger
2020-05-08 15:24 ` Shannon Zhao
2020-05-08 15:25 ` Ard Biesheuvel
2020-05-08 19:15 ` Stefan Berger [this message]
2020-05-12 14:57 ` Igor Mammedov
2020-05-05 16:19 ` [PATCH v2 0/3] vTPM/aarch64 ACPI support Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=260618f0-a6f5-0a5a-2174-f3e33fd221b5@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=ardb@kernel.org \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=gshan@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).